Re: [PATCH v2 3/5] include: Add dxgi1_3.idl

[Henri Verbeet]

On 17 September 2017 at 07:39, Ihsan Akmal <ihsanapps(a)gmail.com> wrote:
> +typedef struct DXGI_MATRIX_3X2_F
> +{
> +    FLOAT _11;
> +    FLOAT _12;
> +    FLOAT _21;
> +    FLOAT _22;
> +    FLOAT _31;
> +    FLOAT _32;
> +} DXGI_MATRIX_3X2_F;
> I'd prefer these as "float", although it doesn't really matter.
> +typedef enum DXGI_FRAME_PRESENTATION_MODE
> +{
> +    DXGI_FRAME_PRESENTATION_MODE_COMPOSED»·····            = 0,
> +    DXGI_FRAME_PRESENTATION_MODE_OVERLAY»······            = 1,
> +    DXGI_FRAME_PRESENTATION_MODE_NONE»·                = 2,
> +    DXGI_FRAME_PRESENTATION_MODE_COMPOSITION_FAILURE»··= 3
> +} DXGI_FRAME_PRESENTATION_MODE;
> You have some stray tabs there. We generally prefer adding a comma
> after the last enum element as well, it makes adding elements a little
> easier. That's pretty minor of course. Applies to
> DXGI_OVERLAY_SUPPORT_FLAG as well.
> +interface IDXGIDevice3 : IDXGIDevice2
> +{
> +    void Trim();
> +};
> Superfluous semicolon. Applies to all the other interfaces as well.
> \ No newline at end of file
> Alexandre fixes these when committing patches, but please end source
> files with a newline.