Re: [PATCH 2/2] wininet: Add a new common module information struct

[Jacek Caban]

Hi Morten,

On 04/16/12 22:03, Morten Rønne wrote:
> typedef struct _HASH_CACHEFILE_ENTRY
>  {
>      CACHEFILE_ENTRY CacheFileEntry;
>      DWORD dwAddressNext;
>      DWORD dwHashTableNumber;
> -    struct _HASH_ENTRY HashTable[HASHTABLE_SIZE];
> -} HASH_CACHEFILE_ENTRY;
> +    HASH_ENTRY HashTable[HASHTABLE_SIZE];
> +} HASH_CACHEFILE_ENTRY, *LPHASH_CACHEFILE_ENTRY;
>
> typedef struct _DIRECTORY_DATA
>  {
> @@ -187,13 +187,56 @@ typedef struct _URLCACHECONTAINER
>      HANDLE hMapping; /* handle of file mapping */
>      DWORD file_size; /* size of file when mapping was opened */
>      HANDLE hMutex; /* handle of mutex */
> -} URLCACHECONTAINER;
> +} URLCACHECONTAINER, *LPURLCACHECONTAINER;

Please don't use this kind of defined. LP* types make the code less
readable for no good reason.

Cheers,
Jacek