[PATCH] http.sys: Initialize address structure before use. (Coverity)

[Alistair Leslie-Hughes]

CID 1453504

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>
---
 dlls/http.sys/http.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dlls/http.sys/http.c b/dlls/http.sys/http.c
index b5d5a219dc..6f56cc6555 100644
--- a/dlls/http.sys/http.c
+++ b/dlls/http.sys/http.c
@@ -1097,6 +1097,7 @@ static NTSTATUS http_add_url(struct request_queue *queue, IRP *irp)
         return STATUS_UNSUCCESSFUL;
     }
 
+    memset( &addr, 0, sizeof(addr) );
     addr.sin_family = AF_INET;
     addr.sin_addr.S_un.S_addr = INADDR_ANY;
     if (bind(s, (struct sockaddr *)&addr, sizeof(addr)) == -1)
-- 
2.17.1

[Zebediah Figura]

On 9/5/19 10:17 PM, Alistair Leslie-Hughes wrote:
> CID 1453504
>
> Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>
> ---
>  dlls/http.sys/http.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/dlls/http.sys/http.c b/dlls/http.sys/http.c
> index b5d5a219dc..6f56cc6555 100644
> --- a/dlls/http.sys/http.c
> +++ b/dlls/http.sys/http.c
> @@ -1097,6 +1097,7 @@ static NTSTATUS http_add_url(struct request_queue *queue, IRP *irp)
>          return STATUS_UNSUCCESSFUL;
>      }
>
> +    memset( &addr, 0, sizeof(addr) );
>      addr.sin_family = AF_INET;
>      addr.sin_addr.S_un.S_addr = INADDR_ANY;
>      if (bind(s, (struct sockaddr *)&addr, sizeof(addr)) == -1)

This clears addr.sin_port, which was set on line 1064.