Re: d3dx9: Implementation of D3DXMatrixDecompose 2/2

[David Adam]

Hi,

some remarks

+    if (((*poutscale).x==0)||((*poutscale).y==0)||((*poutscale).z==0))
should be
+    if ((poutscale->x==0)||(poutscale->y==0)||(poutscale->z==0))

No need to redefine a module fonction
Replace  +    poutscale->x=module(pM->m[0][0],pM->m[0][1],pM->m[0][2]);
by
+
poutscale->x=D3DXVec3Length(&D3DXVECTOR3((pM->m[0][0],pM->m[0][1],pM->m[0][2]));

David


2008/8/5 Luis Busquets <luis.busquets(a)ilidium.com>
> Please be aware that this function relies on D3DXQuaternionRotationMatrix
> and therefore the bug in the latter has to be corrected.
>
> ---
>  dlls/d3dx9_36/d3dx9_36.spec |    2 +-
>  dlls/d3dx9_36/math.c        |   39 ++++++++++++++++++++++++++
>  dlls/d3dx9_36/tests/math.c  |   64
> +++++++++++++++++++++++++++++++++++++++++++
>  include/d3dx9math.h         |    1 +
>  4 files changed, 105 insertions(+), 1 deletions(-)

d3dx9: Implementation of D3DXMatrixDecompose 2/2

[H. Verbeet]

2008/8/5 David Adam <david.adam.cnrs(a)gmail.com>:
> Hi,
>
> some remarks
>
> +    if (((*poutscale).x==0)||((*poutscale).y==0)||((*poutscale).z==0))
> should be
> +    if ((poutscale->x==0)||(poutscale->y==0)||(poutscale->z==0))

To add to that, you really should test your error paths in your test case.

Also:
> +    TRACE("\n");
> That's not a very informative TRACE.