Re: [PATCH 1/5] ddraw: Make the OpenGL renderer the default one.
On Tuesday 30 August 2011 20:12:31 Henri Verbeet wrote:
This imlicitly gets rid of the "auto" option as well, since there's no way to explicitly specify it. This will no doubt cause its share of regressions, but I prefer actually fixing those bugs to running into the surface implementation switching code every time I try to fix something in ddraw. This will break 2D-only apps in situations where OpenGL is not available. It would be a good idea to use SURFACE_GDI automatically in those situations. (I'm not sure if ddraw without GL works at all right now, we have no systems that run the tests with this setup)
It will make it impossible to run some apps out of the box(e.g. the ones currently affected by bug 2082, and old QuickTime versions). That's fine with me, it's not like those apps are working at the moment, and I guess the switching breaks more than it fixes.
On 31 August 2011 10:58, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote:
This will break 2D-only apps in situations where OpenGL is not available. It Well, DirectDraw 2D-only applications, but yes. All three people in that situation should either install a software GL renderer or explicitly set the "DirectDrawRenderer" registry key to "gdi".
It will make it impossible to run some apps out of the box(e.g. the ones currently affected by bug 2082, and old QuickTime versions). That's fine with I'm not sure how this will make it more impossible to fix that bug.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 31.08.2011 um 12:29 schrieb Henri Verbeet:
On 31 August 2011 10:58, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote:
This will break 2D-only apps in situations where OpenGL is not available. It Well, DirectDraw 2D-only applications, but yes. All three people in that situation should either install a software GL renderer or explicitly set the "DirectDrawRenderer" registry key to "gdi". My mail is a bit late, but the programs I'm mainly concerned about are Internet Explorer and Windows Media Player. If someone wants to play a game in a VNC X server that's a crazy enough setup that setting an extra registry key doesn't matter, but running IE in VNC isn't that unusual.
It will make it impossible to run some apps out of the box(e.g. the ones currently affected by bug 2082, and old QuickTime versions). That's fine with I'm not sure how this will make it more impossible to fix that bug. Well, without opengl we can still render to the NULL hwnd, even if it has issues like not working with a compositing Window manager(Windows disables aero when a ddraw app doesn't specify a clipping window). OpenGL refuses to do that.
-----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.17 (Darwin) iQIcBAEBAgAGBQJOXzPPAAoJEN0/YqbEcdMwp0wP/31DLijd+24l30IT0Apk0Gru FyOzYdGynHuZ0AyO0tNa7EH+bAxrrBqNxJw2yuBrcgB5iLoqwE8xehuEVpQ26oA4 JCbd820uPtf8ijnIeTD2wc6UEq8noZfyM+DUo8419w08RrLD5LdB3feHUeWTXZZA iT1UiRmIornAU9HgHpCMBlwmDvSG3EGhtgcRPwo4ABgnvkvn7yiAIH0s8ZUkUgVH I0WtL2Wx7pFWhqbRblsrqTrdUZI0nzkvDuZHoFyU9mVKSX+AMLO/r/1TeC6HynaJ RS11ngFRgogLQFLhxUSocfQk5lccqeb+jw9HtHvKPjWMKHwZLSOJArvGTeMQoujG DDim4tst/7dPKVlU9m29rNijX2iVpGCcwFeeR94XXFj6L9Am6HkapxOJTap+Knl0 gVzYJSRnAITVIa2E9UMicMjU3SifC2+sSgY/J9FGs4yOLqCV0cwRrGmUzcbwYhAu crLPDcnbIzy0H05kKbRTDzA329jH0T4dAFveoyRAIEHTYpI9tWoLVP8yKgJ5edlG wTA+HkU3IhVyQmOVlIWL4pJ6qe5oVQ2aT58WCpxGcWQoZBsJh6mltq6i/zTJcjk8 ZA5hR6SjJOSiY+xVXdjE/zSBUp49rZhhBUzr0CQGQdEiFQvlKIwDiY8TwRrcY3HO encWQArhsqvqeyGyIWzz =YifS -----END PGP SIGNATURE-----
On 1 September 2011 09:27, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote:
Am 31.08.2011 um 12:29 schrieb Henri Verbeet:
Well, DirectDraw 2D-only applications, but yes. All three people in that situation should either install a software GL renderer or explicitly set the "DirectDrawRenderer" registry key to "gdi". My mail is a bit late, but the programs I'm mainly concerned about are Internet Explorer and Windows Media Player. If someone wants to play a game in a VNC X server that's a crazy enough setup that setting an extra registry key doesn't matter, but running IE in VNC isn't that unusual.
So you install a software GL renderer, use something that actually works with indirect GL, or set "DirectDrawRenderer" to "gdi". Plenty of reasonable options to make it work I'd say. If you really want to go out of your way to make this work you can even make the fallback to gdi automatic, but it would have to be before any surfaces or swapchains are created, I'm not putting the surface type switching code back in. Preferably this would work by making the surface type just go away on the wined3d side, and just not exposing any GL based blitters or 3D rendering.
It will make it impossible to run some apps out of the box(e.g. the ones currently affected by bug 2082, and old QuickTime versions). That's fine with I'm not sure how this will make it more impossible to fix that bug. Well, without opengl we can still render to the NULL hwnd, even if it has issues like not working with a compositing Window manager(Windows disables aero when a ddraw app doesn't specify a clipping window). OpenGL refuses to do that. So you don't use GL to render to that. For simple blits, it should be fairly trivial to only use CPU blits when blitting to the root window. For actual 3D rendering you'd have to create an intermediate offscreen target to render to, which is probably somewhat harder. But then, with the GDI renderer this doesn't work at all.
participants (2)
-
Henri Verbeet -
Stefan Dösinger