Re: [PATCH 1/4] dsound: Remove minlen, since we always mix full chunks anyway

[Alexander E. Patrakov]

Andrew Eikum wrote:
> -
> -	TRACE("Mixed at least %d from all buffers\n", minlen);
> -	return minlen;

Hi. You have removed the message that could say "Mixed at least 0 from
all buffers" (as seen, e.g., for Armored Fist 3 and sometimes even for
foobar2000). What was the reason for that "0" (or, rather, 1024, 1024,
1024, 0, 2048, 1024, ... sequence) seen in some games? Was it also fixed
by your patch?

(this mail is a question, not an objection)

-- 
Alexander E. Patrakov

[PATCH 1/4] dsound: Remove minlen, since we always mix full chunks anyway

[Andrew Eikum]

On Tue, May 15, 2012 at 12:33:25PM +0600, Alexander E. Patrakov wrote:
> Andrew Eikum wrote:
> > -
> > -	TRACE("Mixed at least %d from all buffers\n", minlen);
> > -	return minlen;
>
> Hi. You have removed the message that could say "Mixed at least 0 from
> all buffers" (as seen, e.g., for Armored Fist 3 and sometimes even for
> foobar2000). What was the reason for that "0" (or, rather, 1024, 1024,
> 1024, 0, 2048, 1024, ... sequence) seen in some games? Was it also fixed
> by your patch?

That message was made redundant with the one at the beginning of
MixToPrimary, so I removed it. I don't know what causes that hiccup,
but it should still show up in log files in the first MixToPrimary
TRACE.

Andrew