Re: [PATCH] secur32/tests: handle skip cleanup in negotiate more cleanly

[Nikolay Sivov]

On 30.09.2015 19:04, Aric Stewart wrote:
> Signed-off-by: Aric Stewart <aric(a)codeweavers.com>
> ---
>   dlls/secur32/tests/negotiate.c | 31 +++++++++++++++++++++++--------
>   1 file changed, 23 insertions(+), 8 deletions(-)

> -    status_c = pDeleteSecurityContext( &client.ctxt );
> -    ok( status_c == SEC_E_OK, "DeleteSecurityContext returned %08x\n", status_c );
> +    if (client.ctxt.dwLower || client.ctxt.dwUpper)
> +    {
> +        status_c = pDeleteSecurityContext( &client.ctxt );
> +        ok( status_c == SEC_E_OK, "DeleteSecurityContext returned %08x\n", status_c );
> +    }

Why is this a problem only on macos?

[PATCH] secur32/tests: handle skip cleanup in negotiate more cleanly

[Aric Stewart]

On 9/30/15 11:07 AM, Nikolay Sivov wrote:
> On 30.09.2015 19:04, Aric Stewart wrote:
> > Signed-off-by: Aric Stewart <aric(a)codeweavers.com>
> > ---
> >   dlls/secur32/tests/negotiate.c | 31 +++++++++++++++++++++++--------
> >   1 file changed, 23 insertions(+), 8 deletions(-)
> > -    status_c = pDeleteSecurityContext( &client.ctxt );
> > -    ok( status_c == SEC_E_OK, "DeleteSecurityContext returned %08x\n", status_c );
> > +    if (client.ctxt.dwLower || client.ctxt.dwUpper)
> > +    {
> > +        status_c = pDeleteSecurityContext( &client.ctxt );
> > +        ok( status_c == SEC_E_OK, "DeleteSecurityContext returned %08x\n", status_c );
> > +    }
>
> Why is this a problem only on macos?

No idea, Again I was trying to turn a crash into a cleaner failure.

-aric