Re: opengl32: glBindTexture() and glDeleteTextures() require an active GL context
Hi Bruno, My initial feeling is that the app is just buggy, since calling functions without a context is very questionable. Assuming we want to any checking on NULL-contexts, please edit the make_opengl script since opengl_norm.c is all auto-generated. Since this code is tricky, I would recommend writing a test case for our test suite. Years ago (pre-wine 1.0) we had code to keep some implicit GL context around, because allegedly some game required it (I think it was Homeland). Though when I tried to reproduce that behavior I didn't see it in the game. I think I wrote some tests for Windows, but don't remember the results. Thanks, Roderick On Sat, Jun 21, 2014 at 11:36 AM, Bruno Jesus <00cpxxx(a)gmail.com> wrote:
Very similar to bug 36506 but for other functions.
On Sat, Jun 21, 2014 at 5:33 PM, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote:
Hi Bruno,
My initial feeling is that the app is just buggy, since calling functions without a context is very questionable. Assuming we want to any checking on NULL-contexts, please edit the make_opengl script since opengl_norm.c is all auto-generated. Since this code is tricky, I would recommend writing a test case for our test suite. Years ago (pre-wine 1.0) we had code to keep some implicit GL context around, because allegedly some game required it (I think it was Homeland). Though when I tried to reproduce that behavior I didn't see it in the game. I think I wrote some tests for Windows, but don't remember the results.
Hi, thanks for the reply. I agree the app is buggy but as it works in Windows I thought the patch was useful, I tried checking the make_opengl but didn't understand it, there is no glBindTexture there for example. I'll leave the bug to someone else with real experience in the area.
Thanks, Roderick
Best regards, Bruno
Hi Bruno, Regarding the make_opengl script it generates the code from templates from the opengl site. The templates contain all the function definitions. The script has some function which in the end generates code for each function. Look for something common e.g. trace lines to find your way around the script. Thanks, Roderick On Sat, Jun 21, 2014 at 1:39 PM, Bruno Jesus <00cpxxx(a)gmail.com> wrote:
On Sat, Jun 21, 2014 at 5:33 PM, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote:
Hi Bruno,
My initial feeling is that the app is just buggy, since calling functions without a context is very questionable. Assuming we want to any checking on NULL-contexts, please edit the make_opengl script since opengl_norm.c is all auto-generated. Since this code is tricky, I would recommend writing a test case for our test suite. Years ago (pre-wine 1.0) we had code to keep some implicit GL context around, because allegedly some game required it (I think it was Homeland). Though when I tried to reproduce that behavior I didn't see it in the game. I think I wrote some tests for Windows, but don't remember the results.
Hi, thanks for the reply. I agree the app is buggy but as it works in Windows I thought the patch was useful, I tried checking the make_opengl but didn't understand it, there is no glBindTexture there for example. I'll leave the bug to someone else with real experience in the area.
Thanks, Roderick
Best regards, Bruno
On Sat, Jun 21, 2014 at 6:47 PM, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote:
Hi Bruno,
Regarding the make_opengl script it generates the code from templates from the opengl site. The templates contain all the function definitions. The script has some function which in the end generates code for each function. Look for something common e.g. trace lines to find your way around the script.
Please take a look at the attached patch, Sebastian Lackner helped me with the perl code and the patch generates the same changes I manually created in my previous attempt. It's done in a way it will not mess with all functions, only the ones required.
Thanks, Roderick
Best wishes, Bruno
participants (2)
-
Bruno Jesus -
Roderick Colenbrander