Vijay wrote:
Resend. Please let me why this one has been dropped.
I'd guess it's because there's no code in the tree that needs it yet, and no tests for it? - Dan
Hi, We have made the tests and implementation. We are waiting for this to get into the tree. Just ironing out minor issues with our implementation. Once this gets in it would be easy to send in the implementation and tests. Thanks, VJ PS: ----- If implementation and tests are needed, will be sending on thursday as I am on vacation/leave. On 3/20/07, Dan Kegel <dank(a)kegel.com> wrote:
Vijay wrote:
Resend. Please let me why this one has been dropped.
I'd guess it's because there's no code in the tree that needs it yet, and no tests for it? - Dan
"Vijay Kiran Kamuju" <infyquest(a)gmail.com> wrote:
We have made the tests and implementation. We are waiting for this to get into the tree. Just ironing out minor issues with our implementation. Once this gets in it would be easy to send in the implementation and tests.
How this could get in if you didn't bother to fix all the problems pointed out? -- Dmitry.
Hi, Can somebody more experienced than me, please look into this? Modify and Submit to the wine-patches, please anyone who is working on wined3d. I and David Adam put a lotta effort making implementation and tests for d3drm. So that we can make older games that use vector manipulations work, there are bugs in bugzilla that need this functionality. I have a very tough luck getting in my patches. eg: my wininet patches (1yr back, more testcases), comctl monthcal patch(no testcase) and now this d3drm. Please someone help David Adam and Me in this, most of the hardwork is done by David. I dont wanna let him down. I know its very tough to get patches done by newbies to get in, esp wine. Please someone from wined3d please help us. Thanks, VJ On 3/20/07, Dmitry Timoshkov <dmitry(a)codeweavers.com> wrote:
"Vijay Kiran Kamuju" <infyquest(a)gmail.com> wrote:
We have made the tests and implementation. We are waiting for this to get into the tree. Just ironing out minor issues with our implementation. Once this gets in it would be easy to send in the implementation and tests.
How this could get in if you didn't bother to fix all the problems pointed out?
-- Dmitry.
"Vijay Kiran Kamuju" <infyquest(a)gmail.com> wrote:
I have a very tough luck getting in my patches. eg: my wininet patches (1yr back, more testcases), comctl monthcal patch(no testcase) and now this d3drm. Please someone help David Adam and Me in this, most of the hardwork is done by David. I dont wanna let him down. I know its very tough to get patches done by newbies to get in, esp wine.
It's absolutely not hard to get patches accepted, be it Wine or any other project. But it's absolutely required to listen for the comments and fix your work accordingly. I'm sorry, but to me it looks like you either don't understand what people are telling you, or you can't read. -- Dmitry.
On 20.03.2007 09:37, Dmitry Timoshkov wrote:
"Vijay Kiran Kamuju" <infyquest(a)gmail.com> wrote:
I know its very tough to get patches done by newbies to get in, esp wine.
It's absolutely not hard to get patches accepted, be it Wine or any other project. But it's absolutely required to listen for the comments and fix your work accordingly.
Sorry, "listen for the comments" is not entirely correct. Often there are no comments at all and the patches simply don't get applied. If soemone is a newbie and really wants to get his/her patches accepted, mail patches repeatedly once every day until the patches get applied or someone comments. At the same time, ask on IRC why the patches didn't get applied. Regards, Carl-Daniel
"Carl-Daniel Hailfinger" <c-d.hailfinger.devel.2006(a)gmx.net> wrote:
On 20.03.2007 09:37, Dmitry Timoshkov wrote:
"Vijay Kiran Kamuju" <infyquest(a)gmail.com> wrote:
I know its very tough to get patches done by newbies to get in, esp wine.
It's absolutely not hard to get patches accepted, be it Wine or any other project. But it's absolutely required to listen for the comments and fix your work accordingly.
Sorry, "listen for the comments" is not entirely correct. Often there are no comments at all and the patches simply don't get applied.
That's not the case here.
If soemone is a newbie and really wants to get his/her patches accepted, mail patches repeatedly once every day until the patches get applied or someone comments.
It's hard to find a worse suggestion for a person sending patches. As there was explained numerous times it's a very bad idea to flood wine-patches by sending the same patch over and over, it makes a chance of accepting the patch even less possible.
At the same time, ask on IRC why the patches didn't get applied.
http://www.winehq.org/site/sending_patches -- Dmitry.
Vijay wrote:
We have made the tests and implementation. We are waiting for this to get into the tree. Just ironing out minor issues with our implementation. Once this gets in it would be easy to send in the implementation and tests.
You need to submit them all together, I think. - Dan
On 20/03/07, Dan Kegel <dank(a)kegel.com> wrote:
Vijay wrote:
We have made the tests and implementation. We are waiting for this to get into the tree. Just ironing out minor issues with our implementation. Once this gets in it would be easy to send in the implementation and tests.
You need to submit them all together, I think. - Dan
The logical way to split this up would be by function rather than header/implementation/tests.
participants (5)
-
Carl-Daniel Hailfinger -
Dan Kegel -
Dmitry Timoshkov -
H. Verbeet -
Vijay Kiran Kamuju