Re: [3/6] dxgi: Add missing dxgi 1.2 structs and interfaces [try 2]

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Martell,

Looks pretty good, you missed two things:

Am 2015-02-12 um 20:34 schrieb Martell Malone:
> +interface IDXGIOutputDuplication : IDXGIObject {
> { placement.
> +        [in, out] UINT *_countmode,
> [in, out] UINT *mode_count;

After that go ahead and resubmit patches 1-3. Again I recommend to
have a look at git send-email. It's quite simple: What it essentially
comes down to is adding this to wine_src/.git/config:

[sendemail]
        from = Martell Malone <martellmalone(a)gmail.com>
        to = wine-patches <wine-patches(a)winehq.org>
        smtpserver = smtp.googlemail.com
        chainreplyto = false
        thread = false
        smtpencryption = tls
        smtpuser = martellmalone(a)gmail.com
        suppresscc = self

The password was in my case automagically managed by the KDE keychain.

Then you just do "git send-email origin". I recommend a sanity check
with --dry-run first. Feels almost like pushing :-) .

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJU3bobAAoJEN0/YqbEcdMwCO4P/RlJWBhdZlgs2P8uYZosElTi
ofQ2gQNX3Qo53vqwVgtNsmoFyAUHcqUX5euoACeDwjoGpOIe0cJ98ON2sJHADRqa
nUPNjPrh/Xo/5WYhQs04hWGRbaFQTCgS+gjuld2ePqIgnAtl880G8GCptD0elcX2
blwa5nPOcxjzaqWX/BB159oioyfWy/IFC5B55Tb7WshSxpkSwgvWkIQsaO2ttF4B
3reG4z1xvgNJZfNH2MzND+d3EJrIq2iydr9dAS4ph1biEbSnlisFR1PwlVFXI7XT
CGCmJD7eSM5hU3nRFWB8stEUSumwm8IPQXpcN8PSdzjcWwXuJ1lk6t4t2IlPIuET
knXI4D+4XgduVKjBGDxp75fRDL6RmwaRckTnuCLUiCVDcr+bIPHuC1FKFpGxB4Vu
q8FZ4wuo4vTegZ9niwi5FPZxc86zLvh3R1qv8mugLJPGbdl+6HYz6aZVtQRXewAe
nDZg5nE/DxVrzFF/Ehg9gGHtmwkQeNpxbGK+vsv+qU1sqaod7+FQeTDkfCcs/Ola
/7OIdJctBmjpPUGVamVTPUlrRwVNVSboZjDgwN32uBJ/opRFR331HreGL3Aj5UZ1
1EgCcv3tKC8YgiXF7YCrft8EtZFYu/PyZZm0KSjucpGbyviPf03pfNfaj5zPrlMv
k1sPLynBjlhOiOO1HRI8
=3BtO
-----END PGP SIGNATURE-----

[3/6] dxgi: Add missing dxgi 1.2 structs and interfaces [try 2]

[Martell Malone]

Okay I'll sent them in as a group of 3 and send the second 3 separately.
I'll try send-email now

On Fri, Feb 13, 2015 at 8:47 AM, Stefan Dösinger <stefandoesinger(a)gmail.com>
wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi Martell,
>
> Looks pretty good, you missed two things:
>
> Am 2015-02-12 um 20:34 schrieb Martell Malone:
> > +interface IDXGIOutputDuplication : IDXGIObject {
> > { placement.
> > +        [in, out] UINT *_countmode,
> > [in, out] UINT *mode_count;
>
> After that go ahead and resubmit patches 1-3. Again I recommend to
> have a look at git send-email. It's quite simple: What it essentially
> comes down to is adding this to wine_src/.git/config:
>
> [sendemail]
>         from = Martell Malone <martellmalone(a)gmail.com>
>         to = wine-patches <wine-patches(a)winehq.org>
>         smtpserver = smtp.googlemail.com
>         chainreplyto = false
>         thread = false
>         smtpencryption = tls
>         smtpuser = martellmalone(a)gmail.com
>         suppresscc = self
>
> The password was in my case automagically managed by the KDE keychain.
>
> Then you just do "git send-email origin". I recommend a sanity check
> with --dry-run first. Feels almost like pushing :-) .
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2
>
> iQIcBAEBAgAGBQJU3bobAAoJEN0/YqbEcdMwCO4P/RlJWBhdZlgs2P8uYZosElTi
> ofQ2gQNX3Qo53vqwVgtNsmoFyAUHcqUX5euoACeDwjoGpOIe0cJ98ON2sJHADRqa
> nUPNjPrh/Xo/5WYhQs04hWGRbaFQTCgS+gjuld2ePqIgnAtl880G8GCptD0elcX2
> blwa5nPOcxjzaqWX/BB159oioyfWy/IFC5B55Tb7WshSxpkSwgvWkIQsaO2ttF4B
> 3reG4z1xvgNJZfNH2MzND+d3EJrIq2iydr9dAS4ph1biEbSnlisFR1PwlVFXI7XT
> CGCmJD7eSM5hU3nRFWB8stEUSumwm8IPQXpcN8PSdzjcWwXuJ1lk6t4t2IlPIuET
> knXI4D+4XgduVKjBGDxp75fRDL6RmwaRckTnuCLUiCVDcr+bIPHuC1FKFpGxB4Vu
> q8FZ4wuo4vTegZ9niwi5FPZxc86zLvh3R1qv8mugLJPGbdl+6HYz6aZVtQRXewAe
> nDZg5nE/DxVrzFF/Ehg9gGHtmwkQeNpxbGK+vsv+qU1sqaod7+FQeTDkfCcs/Ola
> /7OIdJctBmjpPUGVamVTPUlrRwVNVSboZjDgwN32uBJ/opRFR331HreGL3Aj5UZ1
> 1EgCcv3tKC8YgiXF7YCrft8EtZFYu/PyZZm0KSjucpGbyviPf03pfNfaj5zPrlMv
> k1sPLynBjlhOiOO1HRI8
> =3BtO
> -----END PGP SIGNATURE-----

[3/6] dxgi: Add missing dxgi 1.2 structs and interfaces [try 2]

[Martell Malone]

Wait you want me to change
from
[in, out] UINT *_countmode,
to
[in, out] UINT *mode_count;

Isn't that what you asked me not todo last time ?

On Fri, Feb 13, 2015 at 12:31 PM, Martell Malone <martellmalone(a)gmail.com>
wrote:
> Okay I'll sent them in as a group of 3 and send the second 3 separately.
> I'll try send-email now
>
> On Fri, Feb 13, 2015 at 8:47 AM, Stefan Dösinger <
> stefandoesinger(a)gmail.com> wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > Hi Martell,
> >
> > Looks pretty good, you missed two things:
> >
> > Am 2015-02-12 um 20:34 schrieb Martell Malone:
> > > +interface IDXGIOutputDuplication : IDXGIObject {
> > > { placement.
> > > +        [in, out] UINT *_countmode,
> > > [in, out] UINT *mode_count;
> >
> > After that go ahead and resubmit patches 1-3. Again I recommend to
> > have a look at git send-email. It's quite simple: What it essentially
> > comes down to is adding this to wine_src/.git/config:
> >
> > [sendemail]
> >         from = Martell Malone <martellmalone(a)gmail.com>
> >         to = wine-patches <wine-patches(a)winehq.org>
> >         smtpserver = smtp.googlemail.com
> >         chainreplyto = false
> >         thread = false
> >         smtpencryption = tls
> >         smtpuser = martellmalone(a)gmail.com
> >         suppresscc = self
> >
> > The password was in my case automagically managed by the KDE keychain.
> >
> > Then you just do "git send-email origin". I recommend a sanity check
> > with --dry-run first. Feels almost like pushing :-) .
> >
> > -----BEGIN PGP SIGNATURE-----
> > Version: GnuPG v2
> >
> > iQIcBAEBAgAGBQJU3bobAAoJEN0/YqbEcdMwCO4P/RlJWBhdZlgs2P8uYZosElTi
> > ofQ2gQNX3Qo53vqwVgtNsmoFyAUHcqUX5euoACeDwjoGpOIe0cJ98ON2sJHADRqa
> > nUPNjPrh/Xo/5WYhQs04hWGRbaFQTCgS+gjuld2ePqIgnAtl880G8GCptD0elcX2
> > blwa5nPOcxjzaqWX/BB159oioyfWy/IFC5B55Tb7WshSxpkSwgvWkIQsaO2ttF4B
> > 3reG4z1xvgNJZfNH2MzND+d3EJrIq2iydr9dAS4ph1biEbSnlisFR1PwlVFXI7XT
> > CGCmJD7eSM5hU3nRFWB8stEUSumwm8IPQXpcN8PSdzjcWwXuJ1lk6t4t2IlPIuET
> > knXI4D+4XgduVKjBGDxp75fRDL6RmwaRckTnuCLUiCVDcr+bIPHuC1FKFpGxB4Vu
> > q8FZ4wuo4vTegZ9niwi5FPZxc86zLvh3R1qv8mugLJPGbdl+6HYz6aZVtQRXewAe
> > nDZg5nE/DxVrzFF/Ehg9gGHtmwkQeNpxbGK+vsv+qU1sqaod7+FQeTDkfCcs/Ola
> > /7OIdJctBmjpPUGVamVTPUlrRwVNVSboZjDgwN32uBJ/opRFR331HreGL3Aj5UZ1
> > 1EgCcv3tKC8YgiXF7YCrft8EtZFYu/PyZZm0KSjucpGbyviPf03pfNfaj5zPrlMv
> > k1sPLynBjlhOiOO1HRI8
> > =3BtO
> > -----END PGP SIGNATURE-----

[3/6] dxgi: Add missing dxgi 1.2 structs and interfaces [try 2]

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2015-02-13 um 13:33 schrieb Martell Malone:
> Wait you want me to change
> from
> [in, out] UINT *_countmode,
> to
> [in, out] UINT *mode_count;
> Correct.
> Isn't that what you asked me not todo last time ?
> What I pointed out last time is that you had xxx_count in some places
> and count_xxx in others. I asked you to consistently use names in the
> form of xxx_count.
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2

iQIcBAEBAgAGBQJU3fEVAAoJEN0/YqbEcdMw6OMQAJCwji4sNP/g+8zlpPHmADDW
87rM+ORSskagtHyfAfhhnchwTarzxfYLUEPP6AfeGox7lzQ41n7axh7PoBjWRsK0
8Nzlo0X2o6hvID0NsD9uYnLQwn1Z7I9iLhJujEEB4wBk9oo34ZKStU2GqyeNQplO
D5t+0sWGycEZKiQFIT/Nu9gv2WWq+096LaaxniulYU+DOzp/pCr62y3kiP68PpVO
8GXR13F4hDOf6gRbtaN6GVR/ZcixkhHikoPbxLtnTdbicWcuaofySDkNQLDMF6yS
qP7pDwkQM2MyZLQR93r3W+Rgu33o/mt8vpG1Y4SmcS/flRY3VzSxNY36kriubuCQ
rchcFq9xWtJ0nz6ycyeGNormnsHXu6ZWLr6C66iDZla24N/iIljEh53r7ggAEM9I
pq4ENHMgu4Z/R1yN8c3Q7jdiN8Q5Y0/2rXeln8qLzWFu8876OX2+88HNcTr7qRU0
x0AZhoxyyPxXmyDpckAZhMuiXsMzVySLFOm6osGH6EZWP84S0+ZMNVtKzOtd1irQ
3+VWUl3hu1oTiFk+V5q6Si1g/Ih+Zl7WQXqqvzuHoTmhFZiwrAAfcLXTOUkwuvGq
tw/r3pEcYKhYU2EpC5mNS03lsywtrDX+TNG8Sa7ztmDQgCb6NUdX2lAVBvP7PLvt
jcBV5ZLAhwhPiMuRpGpd
=tmI4
-----END PGP SIGNATURE-----

[3/6] dxgi: Add missing dxgi 1.2 structs and interfaces [try 2]

[Martell Malone]

> What I pointed out last time is that you had xxx_count in some places
> and count_xxx in others. I asked you to consistently use names in the
> form of xxx_count.

Checking back over my emails it was henri who said that he wanted it in the
form _count

- I prefer the order of things to be macros/constants, enums,
> structs, interfaces, functions instead of having those interleaved
> through the header.
>   - "FLOAT" -> "float", "LPCWSTR" -> "const WCHAR *"
>   - "num_*" -> "*_count"

It's hard to keep track of what to do :(

On Fri, Feb 13, 2015 at 12:41 PM, Stefan Dösinger <stefandoesinger(a)gmail.com
> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Am 2015-02-13 um 13:33 schrieb Martell Malone:
> > Wait you want me to change
> > from
> > [in, out] UINT *_countmode,
> > to
> > [in, out] UINT *mode_count;
> > Correct.
> > Isn't that what you asked me not todo last time ?
> > What I pointed out last time is that you had xxx_count in some places
> > and count_xxx in others. I asked you to consistently use names in the
> > form of xxx_count.
> > -----BEGIN PGP SIGNATURE-----
> > Version: GnuPG v2
>
> iQIcBAEBAgAGBQJU3fEVAAoJEN0/YqbEcdMw6OMQAJCwji4sNP/g+8zlpPHmADDW
> 87rM+ORSskagtHyfAfhhnchwTarzxfYLUEPP6AfeGox7lzQ41n7axh7PoBjWRsK0
> 8Nzlo0X2o6hvID0NsD9uYnLQwn1Z7I9iLhJujEEB4wBk9oo34ZKStU2GqyeNQplO
> D5t+0sWGycEZKiQFIT/Nu9gv2WWq+096LaaxniulYU+DOzp/pCr62y3kiP68PpVO
> 8GXR13F4hDOf6gRbtaN6GVR/ZcixkhHikoPbxLtnTdbicWcuaofySDkNQLDMF6yS
> qP7pDwkQM2MyZLQR93r3W+Rgu33o/mt8vpG1Y4SmcS/flRY3VzSxNY36kriubuCQ
> rchcFq9xWtJ0nz6ycyeGNormnsHXu6ZWLr6C66iDZla24N/iIljEh53r7ggAEM9I
> pq4ENHMgu4Z/R1yN8c3Q7jdiN8Q5Y0/2rXeln8qLzWFu8876OX2+88HNcTr7qRU0
> x0AZhoxyyPxXmyDpckAZhMuiXsMzVySLFOm6osGH6EZWP84S0+ZMNVtKzOtd1irQ
> 3+VWUl3hu1oTiFk+V5q6Si1g/Ih+Zl7WQXqqvzuHoTmhFZiwrAAfcLXTOUkwuvGq
> tw/r3pEcYKhYU2EpC5mNS03lsywtrDX+TNG8Sa7ztmDQgCb6NUdX2lAVBvP7PLvt
> jcBV5ZLAhwhPiMuRpGpd
> =tmI4
> -----END PGP SIGNATURE-----

[3/6] dxgi: Add missing dxgi 1.2 structs and interfaces [try 2]

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2015-02-13 um 13:46 schrieb Martell Malone:
> > What I pointed out last time is that you had xxx_count in some 
> > places and count_xxx in others. I asked you to consistently use 
> > names in the form of xxx_count.
>
> Checking back over my emails it was henri who said that he wanted 
> it in the form _count
> With *_count he meant the same as I mean with xxx_count. E.g.
> mode_count, level_count, etc. The * in this case is not a C pointer
> but supposed to be a wildcard.
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2

iQIcBAEBAgAGBQJU3fOhAAoJEN0/YqbEcdMwUkwP+gJI4C+K53BLKGc6kRKZ5CzR
E1IfqRtBcsp6132ZRgXVhDAGRFvVwPa5N4WRt5xraSQqK3pS5wqY5cPoeutAk77J
akT86Z8MH1nPnvdARv3Gpy/GWQe/NXB76OXKd1aErYvM2HoFGFRxs5dhH07NcjVd
gkXJZLS40ZrRPSqOXvdtpqXpV1e3A4iBiSb8xrNibLahl6tY7qlh5e8iZ9Be1nfe
9KdjbmU9WZgSHnS8uymCtY3qdRu7ZLw+Flc0CJarCsZw75Ja8ykUlalBtbgO4P+M
tmO2zjizU4Nkb80kI9nq1bWBBcQOk5F04geOMZ00qM3GrZ1z4c5Jm9GSeM6Q0J5Q
B0RalaKqKGFjD3szXs4knt/1RL5fI5loQsn+K3GbJ7qWw98tJnOcf/PeEqhchC+p
Mrnsu7OEizDslUCX5+EMAmeOhvxqcqHDkUjOW4FoFg3/sAsjH1pg/c+dApWYcOb4
dsK0MeGbB3PvHLSM0uZfjpSCelpu5bjRlYC7ZJ6gGtrRQX92KxZqP85Jz1hT4O03
SMQfpJCjP1ztKWIgNXXyBR7tskv3gtd0WVfkUAb9M+D3Q53WvkE3wNVkoe5/vsaF
tKHBipjDd51bSOS4v5QOdahUW8BLk2BrC4KUk77Dm28E+1RNO3XR9Lv/gWGqk+qF
3+OtM2ntfDfyhr+lGx83
=JTsL
-----END PGP SIGNATURE-----

[3/6] dxgi: Add missing dxgi 1.2 structs and interfaces [try 2]

[Martell Malone]

Ahh I see.
Thanks for clearing that up :)

On Fri, Feb 13, 2015 at 12:52 PM, Stefan Dösinger <stefandoesinger(a)gmail.com
> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Am 2015-02-13 um 13:46 schrieb Martell Malone:
> > > What I pointed out last time is that you had xxx_count in some
> > > places and count_xxx in others. I asked you to consistently use
> > > names in the form of xxx_count.
> >
> > Checking back over my emails it was henri who said that he wanted
> > it in the form _count
> > With *_count he meant the same as I mean with xxx_count. E.g.
> > mode_count, level_count, etc. The * in this case is not a C pointer
> > but supposed to be a wildcard.
> > -----BEGIN PGP SIGNATURE-----
> > Version: GnuPG v2
>
> iQIcBAEBAgAGBQJU3fOhAAoJEN0/YqbEcdMwUkwP+gJI4C+K53BLKGc6kRKZ5CzR
> E1IfqRtBcsp6132ZRgXVhDAGRFvVwPa5N4WRt5xraSQqK3pS5wqY5cPoeutAk77J
> akT86Z8MH1nPnvdARv3Gpy/GWQe/NXB76OXKd1aErYvM2HoFGFRxs5dhH07NcjVd
> gkXJZLS40ZrRPSqOXvdtpqXpV1e3A4iBiSb8xrNibLahl6tY7qlh5e8iZ9Be1nfe
> 9KdjbmU9WZgSHnS8uymCtY3qdRu7ZLw+Flc0CJarCsZw75Ja8ykUlalBtbgO4P+M
> tmO2zjizU4Nkb80kI9nq1bWBBcQOk5F04geOMZ00qM3GrZ1z4c5Jm9GSeM6Q0J5Q
> B0RalaKqKGFjD3szXs4knt/1RL5fI5loQsn+K3GbJ7qWw98tJnOcf/PeEqhchC+p
> Mrnsu7OEizDslUCX5+EMAmeOhvxqcqHDkUjOW4FoFg3/sAsjH1pg/c+dApWYcOb4
> dsK0MeGbB3PvHLSM0uZfjpSCelpu5bjRlYC7ZJ6gGtrRQX92KxZqP85Jz1hT4O03
> SMQfpJCjP1ztKWIgNXXyBR7tskv3gtd0WVfkUAb9M+D3Q53WvkE3wNVkoe5/vsaF
> tKHBipjDd51bSOS4v5QOdahUW8BLk2BrC4KUk77Dm28E+1RNO3XR9Lv/gWGqk+qF
> 3+OtM2ntfDfyhr+lGx83
> =JTsL
> -----END PGP SIGNATURE-----