Re: [ddraw] fix bug 3487: don't crash if pDDSD is NULL

[Vitaliy Margolen]

Thursday, October 6, 2005, 1:31:09 AM, Raphael wrote:
> Hi,
>  Changelog:
>   - fix 3487: don't crash if pDDSD is NULL on DirectDrawSurface::Lock
> Regards,
> Raphael
> +    if (NULL == lpddsd) {
> +      DPRINTF("(null)\n");
>      } else {
> Please don't use DPFINTF
> +      if (lpddsd->>dwSize >= sizeof(DDSURFACEDESC2)) {
> +        DDRAW_dump_members(lpddsd->dwFlags, lpddsd, members_caps2, 1);
> +      } else {
> And follow the same indentation style (4 spaces):

Vitaliy Margolen

[ddraw] fix bug 3487: don't crash if pDDSD is NULL

[Raphael]

On Thursday 06 October 2005 09:38, Vitaliy Margolen wrote:
> Thursday, October 6, 2005, 1:31:09 AM, Raphael wrote:
> > Hi,
> >  Changelog:
> >   - fix 3487: don't crash if pDDSD is NULL on DirectDrawSurface::Lock
> > Regards,
> > Raphael
> > +    if (NULL == lpddsd) {
> > +      DPRINTF("(null)\n");
> >      } else {
>
> Please don't use DPFINTF

Why ? I use DPRINTF as all used by all ddraw-utils traces
> > +      if (lpddsd->>dwSize >= sizeof(DDSURFACEDESC2)) {
> > +        DDRAW_dump_members(lpddsd->dwFlags, lpddsd, members_caps2, 1);
> > +      } else {
>
> And follow the same indentation style (4 spaces):

emacs is my friend :)
> Vitaliy Margolen

Regards,
Raphael

[ddraw] fix bug 3487: don't crash if pDDSD is NULL

[Peter Berg Larsen]

The subject is wrong. It does not fix 3487, it only fixes a ddraw debug-bug.

Peter