Re: ddraw: Ensure fullscreen size of fullscreen windows

[Stefan Dösinger]

Am 27.07.2010 um 00:19 schrieb Johan Gill:
> This patch fixes the long-standing regression bug 17215.
>
> Enjoy, and provide feedback if you don't ;)
> <17215.txt>
> Usually wined3d does the window setup. I recommend to take a look at WineD3D's AcquireFocusWindow and SetDisplayMode

The problem is somewhat more complicated though - there's swapchain_setup_fullscreen_window and swapchain_restore_fullscreen_window, but wined3ddevice::Setdisplaymode doesn't call the swapchain(because there may not be one if ddraw hasn't created the primary surface yet).

ddraw: Ensure fullscreen size of fullscreen windows

[Johan Gill]

On Tue, Jul 27, 2010 at 12:22 PM, Stefan Dösinger
<stefandoesinger(a)gmx.at> wrote:
> Am 27.07.2010 um 00:19 schrieb Johan Gill:
> > This patch fixes the long-standing regression bug 17215.
> >
> > Enjoy, and provide feedback if you don't ;)
> > <17215.txt>
> > Usually wined3d does the window setup. I recommend to take a look at WineD3D's AcquireFocusWindow and SetDisplayMode
>
> The problem is somewhat more complicated though - there's swapchain_setup_fullscreen_window and swapchain_restore_fullscreen_window, but wined3ddevice::Setdisplaymode doesn't call the swapchain(because there may not be one if ddraw hasn't created the primary surface yet).

I would say that we need to pull the WineD3DDevice into the game as
soon as we go fullscreen then. I didn't look that closely on that code
yet, but I guess it takes some changes there to have it fly without a
surface.

/Johan Gill

ddraw: Ensure fullscreen size of fullscreen windows

[Johan Gill]

On Tue, Jul 27, 2010 at 1:44 PM, Johan Gill <johan.gill(a)gmail.com> wrote:
> On Tue, Jul 27, 2010 at 12:22 PM, Stefan Dösinger
> <stefandoesinger(a)gmx.at> wrote:
> > Usually wined3d does the window setup. I recommend to take a look at WineD3D's AcquireFocusWindow and SetDisplayMode
> >
> > The problem is somewhat more complicated though - there's swapchain_setup_fullscreen_window and swapchain_restore_fullscreen_window, but wined3ddevice::Setdisplaymode doesn't call the swapchain(because there may not be one if ddraw hasn't created the primary surface yet).
>
> I would say that we need to pull the WineD3DDevice into the game as
> soon as we go fullscreen then. I didn't look that closely on that code
> yet, but I guess it takes some changes there to have it fly without a
> surface.
>
> /Johan Gill

Hmm, I need to read up on the wined3d<->ddraw interaction a bit before
trying to say anything further. Anyway, I just submitted a patch with
just the new test case.

/Johan Gill