Re: [RESENT] Don't duplicate handles for _get_osfhandle

[Alexandre Julliard]

Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> writes:
> Changelog:
>   wine/dlls/msvcrt/file.c: _get_osfhandle
>   Don't duplicate handles, otherwise they leak
>
> This time with test case that fails without the patch (but succeed with
> native msvcrt).

It would be nice to also add a test for the case that the
DuplicateHandle was supposed to fix, so that we can avoid
reintroducing that bug.

-- 
Alexandre Julliard
julliard(a)winehq.org

[RESENT] Don't duplicate handles for _get_osfhandle

[Uwe Bonnes]

> > > > > "Alexandre" == Alexandre Julliard <julliard(a)winehq.org> writes:

Alexandre> Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> writes:
    >> Changelog: wine/dlls/msvcrt/file.c: _get_osfhandle Don't duplicate
    >> handles, otherwise they leak
    >> 
    >> This time with test case that fails without the patch (but succeed
    >> with native msvcrt).

    Alexandre> It would be nice to also add a test for the case that the
    Alexandre> DuplicateHandle was supposed to fix, so that we can avoid
    Alexandre> reintroducing that bug.

I will try to write more test this weekend.
-- 
Uwe Bonnes                bon(a)elektron.ikp.physik.tu-darmstadt.de

Institut fuer Kernphysik  Schlossgartenstrasse 9  64289 Darmstadt
--------- Tel. [phone] -------- Fax. [phone] ----------