Re: V2 msvcp100: add time_get::get function with format parameters, add missing arm exports for time_get::get functions

[Piotr Caban]

Hi,

On 11/07/17 12:01, Vijay Kiran Kamuju wrote:
> +@ cdecl -arch=win64 ?get@?$time_get(a)DV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@std@@@std@@QEBA?AV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@2(a)V32@0AEAVios_base(a)2@AEAHPEAUtm@@PEBD4(a)Z(ptr ptr ptr long ptr long ptr ptr ptr ptr ptr) time_get_char_get_fmt
> You have missed the win64 change in msvcp100.spec file.
> +@ cdecl -arch=win64 
> ?get@?$time_get(a)DV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@std@@@std@@QEBA?AV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@2(a)V32@0AEAVios_base(a)2@AEAHPEAUtm@@PEBD4(a)Z(ptr 
> ptr ptr ptr ptr ptr ptr ptr ptr ptr ptr) time_get_char_get_fmt
> The function is taking 9 ptr parameters in 64-bit case (not 11).

Thanks,
Piotr

V2 msvcp100: add time_get::get function with format parameters, add missing arm exports for time_get::get functions

[Vijay Kiran Kamuju]

Aaah crap, I missed it (copy-pasta error).

Will do the change and resend.

Thanks for pointing out.

Thanks,
Vijay

On Tue, Nov 7, 2017 at 12:56 PM, Piotr Caban <piotr.caban(a)gmail.com> wrote:
> Hi,
>
> On 11/07/17 12:01, Vijay Kiran Kamuju wrote:
> > +@ cdecl -arch=win64
> > ?get@?$time_get(a)DV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@std@@@std@@QEBA?AV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@2(a)V32@0AEAVios_base(a)2@AEAHPEAUtm@@PEBD4(a)Z(ptr
> > ptr ptr long ptr long ptr ptr ptr ptr ptr) time_get_char_get_fmt
>
> You have missed the win64 change in msvcp100.spec file.
> > +@ cdecl -arch=win64
> > ?get@?$time_get(a)DV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@std@@@std@@QEBA?AV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@2(a)V32@0AEAVios_base(a)2@AEAHPEAUtm@@PEBD4(a)Z(ptr
> > ptr ptr ptr ptr ptr ptr ptr ptr ptr ptr) time_get_char_get_fmt
> > The function is taking 9 ptr parameters in 64-bit case (not 11).
>
> Thanks,
> Piotr

V2 msvcp100: add time_get::get function with format parameters, add missing arm exports for time_get::get functions

[Vijay Kiran Kamuju]

Hi Piotr,

Are you sure about
+@ cdecl -arch=win64
?get@?$time_get(a)DV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@std@@@std@@QEBA?AV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@2(a)V32@0AEAVios_base(a)2@AEAHPEAUtm@@PEBD4(a)Z(ptr
ptr ptr ptr ptr ptr ptr ptr ptr ptr ptr) time_get_char_get_fmt

taking 9 arguments instead of 11, as per the function signature - 11
seems correct.

Thanks,
Vijay

On Tue, Nov 7, 2017 at 1:59 PM, Vijay Kiran Kamuju <infyquest(a)gmail.com> wrote:
> Aaah crap, I missed it (copy-pasta error).
>
> Will do the change and resend.
>
> Thanks for pointing out.
>
> Thanks,
> Vijay
>
> On Tue, Nov 7, 2017 at 12:56 PM, Piotr Caban <piotr.caban(a)gmail.com> wrote:
> > Hi,
> >
> > On 11/07/17 12:01, Vijay Kiran Kamuju wrote:
> > > +@ cdecl -arch=win64
> > > ?get@?$time_get(a)DV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@std@@@std@@QEBA?AV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@2(a)V32@0AEAVios_base(a)2@AEAHPEAUtm@@PEBD4(a)Z(ptr
> > > ptr ptr long ptr long ptr ptr ptr ptr ptr) time_get_char_get_fmt
> >
> > You have missed the win64 change in msvcp100.spec file.
> > > +@ cdecl -arch=win64
> > > ?get@?$time_get(a)DV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@std@@@std@@QEBA?AV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@2(a)V32@0AEAVios_base(a)2@AEAHPEAUtm@@PEBD4(a)Z(ptr
> > > ptr ptr ptr ptr ptr ptr ptr ptr ptr ptr) time_get_char_get_fmt
> > > The function is taking 9 ptr parameters in 64-bit case (not 11).
> >
> > Thanks,
> > Piotr

V2 msvcp100: add time_get::get function with format parameters, add missing arm exports for time_get::get functions

[Vijay Kiran Kamuju]

Hi,

May be i messed it up.
Ignore the previous mail, too much work at office.

Thanks,
Vijay

On Tue, Nov 7, 2017 at 8:00 PM, Vijay Kiran Kamuju <infyquest(a)gmail.com> wrote:
> Hi Piotr,
>
> Are you sure about
> +@ cdecl -arch=win64
> ?get@?$time_get(a)DV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@std@@@std@@QEBA?AV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@2(a)V32@0AEAVios_base(a)2@AEAHPEAUtm@@PEBD4(a)Z(ptr
> ptr ptr ptr ptr ptr ptr ptr ptr ptr ptr) time_get_char_get_fmt
>
> taking 9 arguments instead of 11, as per the function signature - 11
> seems correct.
>
> Thanks,
> Vijay
>
> On Tue, Nov 7, 2017 at 1:59 PM, Vijay Kiran Kamuju <infyquest(a)gmail.com> wrote:
> > Aaah crap, I missed it (copy-pasta error).
> >
> > Will do the change and resend.
> >
> > Thanks for pointing out.
> >
> > Thanks,
> > Vijay
> >
> > On Tue, Nov 7, 2017 at 12:56 PM, Piotr Caban <piotr.caban(a)gmail.com> wrote:
> > > Hi,
> > >
> > > On 11/07/17 12:01, Vijay Kiran Kamuju wrote:
> > > > +@ cdecl -arch=win64
> > > > ?get@?$time_get(a)DV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@std@@@std@@QEBA?AV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@2(a)V32@0AEAVios_base(a)2@AEAHPEAUtm@@PEBD4(a)Z(ptr
> > > > ptr ptr long ptr long ptr ptr ptr ptr ptr) time_get_char_get_fmt
> > >
> > > You have missed the win64 change in msvcp100.spec file.
> > > > +@ cdecl -arch=win64
> > > > ?get@?$time_get(a)DV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@std@@@std@@QEBA?AV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@2(a)V32@0AEAVios_base(a)2@AEAHPEAUtm@@PEBD4(a)Z(ptr
> > > > ptr ptr ptr ptr ptr ptr ptr ptr ptr ptr) time_get_char_get_fmt
> > > > The function is taking 9 ptr parameters in 64-bit case (not 11).
> > >
> > > Thanks,
> > > Piotr