[PATCH 1/7] win32u: Use syscall interface for some path functions.

[Jacek Caban]

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>
---
  dlls/win32u/gdiobj.c         |  3 ---
  dlls/win32u/syscall.c        |  3 +++
  dlls/win32u/win32u.spec      |  6 +++---
  dlls/win32u/win32u_private.h |  3 ---
  dlls/win32u/wrappers.c       | 15 ---------------
  dlls/wow64win/gdi.c          | 24 ++++++++++++++++++++++++
  dlls/wow64win/syscall.h      |  3 +++
  7 files changed, 33 insertions(+), 24 deletions(-)

[Huw Davies]

Signed-off-by: Huw Davies <huw(a)codeweavers.com>

[Dmitry Timoshkov]

Hi Jacek,

Jacek Caban <jacek(a)codeweavers.com> wrote:
> +NTSTATUS WINAPI wow64_NtGdiGetPath( UINT *args )
> +{
> +    HDC hdc = get_handle( &args );
> +    POINT *points = get_ptr( &args );
> +    BYTE *types = get_ptr( &args );
> +    INT size = get_ulong( &args );
> +
> +    return NtGdiGetPath( hdc, points, types, size );
> +}
> +
> +NTSTATUS WINAPI wow64_NtGdiPathToRegion( UINT *args )
> +{
> +    HDC hdc = get_handle( &args );
> +
> +    return HandleToUlong( NtGdiPathToRegion( hdc ));
> +}
> +
> +NTSTATUS WINAPI wow64_NtGdiFlattenPath( UINT *args )
> +{
> +    HDC hdc = get_handle( &args );
> +
> +    return NtGdiFlattenPath( hdc );
> +}

This doesn't look right that wow64 versions return NTSTATUS. Is that correct?

-- 
Dmitry.

[Jacek Caban]

On 10/12/21 6:02 PM, Dmitry Timoshkov wrote:
> Hi Jacek,
>
> Jacek Caban <jacek(a)codeweavers.com> wrote:
> > +NTSTATUS WINAPI wow64_NtGdiGetPath( UINT *args )
> > +{
> > +    HDC hdc = get_handle( &args );
> > +    POINT *points = get_ptr( &args );
> > +    BYTE *types = get_ptr( &args );
> > +    INT size = get_ulong( &args );
> > +
> > +    return NtGdiGetPath( hdc, points, types, size );
> > +}
> > +
> > +NTSTATUS WINAPI wow64_NtGdiPathToRegion( UINT *args )
> > +{
> > +    HDC hdc = get_handle( &args );
> > +
> > +    return HandleToUlong( NtGdiPathToRegion( hdc ));
> > +}
> > +
> > +NTSTATUS WINAPI wow64_NtGdiFlattenPath( UINT *args )
> > +{
> > +    HDC hdc = get_handle( &args );
> > +
> > +    return NtGdiFlattenPath( hdc );
> > +}
> > This doesn't look right that wow64 versions return NTSTATUS. Is that correct?

The exact type is not very important. NTSTATUS is what all ntdll 
syscalls, so wow64 functions just use that, but they really just return 
a 32-bit value.


Jacek