[PATCH 2/2] ntdll: RtlGetNtProductType() should not validate 'type' parameter.

[Serge Gautherie]

Signed-off-by: Serge Gautherie <winehq-git_serge_180711(a)gautherie.fr>
---
 dlls/ntdll/version.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/ntdll/version.c b/dlls/ntdll/version.c
index 61e48f6..e03bc69 100644
--- a/dlls/ntdll/version.c
+++ b/dlls/ntdll/version.c
@@ -637,7 +637,7 @@ void WINAPI RtlGetNtVersionNumbers( LPDWORD major, LPDWORD minor, LPDWORD build
  */
 BOOLEAN WINAPI RtlGetNtProductType( LPDWORD type )
 {
-    if (type) *type = current_version->wProductType;
+    *type = current_version->wProductType;
     return TRUE;
 }
 
-- 
2.10.0.windows.1

[Gabriel Ivăncescu]

Hi Serge,

On 28/02/2020 13:11, Serge Gautherie wrote:
> Signed-off-by: Serge Gautherie <winehq-git_serge_180711(a)gautherie.fr>
> ---
>   dlls/ntdll/version.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dlls/ntdll/version.c b/dlls/ntdll/version.c
> index 61e48f6..e03bc69 100644
> --- a/dlls/ntdll/version.c
> +++ b/dlls/ntdll/version.c
> @@ -637,7 +637,7 @@ void WINAPI RtlGetNtVersionNumbers( LPDWORD major, LPDWORD minor, LPDWORD build
>    */
>   BOOLEAN WINAPI RtlGetNtProductType( LPDWORD type )
>   {
> -    if (type) *type = current_version->wProductType;
> +    *type = current_version->wProductType;
>       return TRUE;
>   }

Does some app depend on this?

[Serge Gautherie]

On 28/02/2020 14:23, Gabriel Ivăncescu wrote:
> Does some app depend on this?

I don't know. Hopefully not.
Nonetheless, current behavior (no result and return TRUE) seems somewhat 
inconsistent, but I am not working on that currently.

I'll add an additional testcase that does depend on this.

--