Re: [PATCH 4/6] d3dx9: Evaluate condition if parameter can be directly copied during initialization.

[Matteo Bruni]

2017-05-24 11:46 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>:

The patch subject is a bit cumbersome IMO, what about "d3dx9: Add a
direct copy path to set_constants()."?

[PATCH 4/6] d3dx9: Evaluate condition if parameter can be directly copied during initialization.

[Paul Gofman]

On 05/29/2017 09:21 PM, Matteo Bruni wrote:
> 2017-05-24 11:46 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>:
>
> The patch subject is a bit cumbersome IMO, what about "d3dx9: Add a
> direct copy path to set_constants()."?

But direct copy path is already there, I am just moving lengthy 
condition evaluation for that to the initialization where it is stored 
in the structure (and this is used during initialization also in the 
next patch). Maybe "d3dx9: Add a direct copy condition to struct 
param_eval_output"?

[PATCH 4/6] d3dx9: Evaluate condition if parameter can be directly copied during initialization.

[Matteo Bruni]

2017-05-29 20:35 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>:
> On 05/29/2017 09:21 PM, Matteo Bruni wrote:
> > 2017-05-24 11:46 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>:
> >
> > The patch subject is a bit cumbersome IMO, what about "d3dx9: Add a
> > direct copy path to set_constants()."?
>
> But direct copy path is already there, I am just moving lengthy condition
> evaluation for that to the initialization where it is stored in the
> structure (and this is used during initialization also in the next patch).
> Maybe "d3dx9: Add a direct copy condition to struct param_eval_output"?

Eh, right. Dunno, "d3dx9: Precompute and store a constant direct copy flag."?