Re: [PATCH 3/6] user32: Export WINPOS_GetMinMaxInfo() as __wine_get_min_max_info() so it can be called by drivers.

[Dmitry Timoshkov]

Ken Thomases <ken(a)codeweavers.com> wrote:
> +@ cdecl __wine_get_min_max_info(long ptr ptr ptr ptr) WINPOS_GetMinMaxInfo

What's wrong with calling SendMessage(WM_GETMINMAXINFO) from the driver?

-- 
Dmitry.

[PATCH 3/6] user32: Export WINPOS_GetMinMaxInfo() as __wine_get_min_max_info() so it can be called by drivers.

[Ken Thomases]

On Sep 12, 2013, at 12:23 AM, Dmitry Timoshkov wrote:
> Ken Thomases <ken(a)codeweavers.com> wrote:
> > +@ cdecl __wine_get_min_max_info(long ptr ptr ptr ptr) WINPOS_GetMinMaxInfo
>
> What's wrong with calling SendMessage(WM_GETMINMAXINFO) from the driver?

Because I would have to duplicate all of the rest of the logic in WINPOS_GetMinMaxInfo(), too.

-Ken

[PATCH 3/6] user32: Export WINPOS_GetMinMaxInfo() as __wine_get_min_max_info() so it can be called by drivers.

[Dmitry Timoshkov]

Ken Thomases <ken(a)codeweavers.com> wrote:
> > > +@ cdecl __wine_get_min_max_info(long ptr ptr ptr ptr) WINPOS_GetMinMaxInfo
> >
> > What's wrong with calling SendMessage(WM_GETMINMAXINFO) from the driver?
>
> Because I would have to duplicate all of the rest of the logic in WINPOS_GetMinMaxInfo(), too.

Do you really need anything besides ptMaxSize? In any way even duplicating
some of that code is cleaner than adding one more private export IMHO.

-- 
Dmitry.

[PATCH 3/6] user32: Export WINPOS_GetMinMaxInfo() as __wine_get_min_max_info() so it can be called by drivers.

[Ken Thomases]

On Sep 12, 2013, at 10:48 AM, Dmitry Timoshkov wrote:
> Ken Thomases <ken(a)codeweavers.com> wrote:
> > > > +@ cdecl __wine_get_min_max_info(long ptr ptr ptr ptr) WINPOS_GetMinMaxInfo
> > >
> > > What's wrong with calling SendMessage(WM_GETMINMAXINFO) from the driver?
> >
> > Because I would have to duplicate all of the rest of the logic in WINPOS_GetMinMaxInfo(), too.
>
> Do you really need anything besides ptMaxSize? In any way even duplicating
> some of that code is cleaner than adding one more private export IMHO.

I don't use ptMaxSize currently.  I use ptMinTrackSize and ptMaxTrackSize.

As to which is cleaner, I guess I'll wait to see which Alexandre prefers.

-Ken