Re: [2/4] windowscodecs: Implement a better stub for MetadataHandler_GetCount.

[Vincent Povirk]

It should be trivial to implement this correctly.

On Wed, Jun 6, 2012 at 11:21 PM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote:
> ---
>  dlls/windowscodecs/metadatahandler.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/dlls/windowscodecs/metadatahandler.c b/dlls/windowscodecs/metadatahandler.c
> index 013fe04..0ea404b 100644
> --- a/dlls/windowscodecs/metadatahandler.c
> +++ b/dlls/windowscodecs/metadatahandler.c
> @@ -152,7 +152,8 @@ static HRESULT WINAPI MetadataHandler_GetCount(IWICMetadataWriter *iface,
>     if (!pcCount) return E_INVALIDARG;
>
>     FIXME("(%p,%p): stub\n", iface, pcCount);
> -    return E_NOTIMPL;
> +    *pcCount = 0;
> +    return S_OK;
>  }
>
>  static HRESULT WINAPI MetadataHandler_GetValueByIndex(IWICMetadataWriter *iface,
> --
> 1.7.10.1

[2/4] windowscodecs: Implement a better stub for MetadataHandler_GetCount.

[Dmitry Timoshkov]

Vincent Povirk <madewokherd(a)gmail.com> wrote:
> It should be trivial to implement this correctly.

Returning 0 is suffice for now. Once metadata handlers start parsing and
returning actual data, a real implementation will be added.

-- 
Dmitry.