Re: [PATCH 1/3] advpack/tests: Rename the wrappers around HeapAlloc() &Co to use the new standard naming.

[James Hawkins]

On Nov 28, 2007 3:39 PM, Michael Stefaniuc <mstefani(a)redhat.de> wrote:
> Alexandre,
>
> i'm unsure about this patch series. Yes this are simple wrappers around
> HeapAlloc() that are the same as the "standard" wrappers used in Wine.
> But they are used only as callbacks aka different usage.

I don't think this particular series is beneficial.  Your script won't
be able to use these names because they're not called directly.

-- 
James Hawkins

[PATCH 1/3] advpack/tests: Rename the wrappers around HeapAlloc() &Co to use the new standard naming.

[Michael Stefaniuc]

James Hawkins wrote:
> On Nov 28, 2007 3:39 PM, Michael Stefaniuc <mstefani(a)redhat.de> wrote:
> > i'm unsure about this patch series. Yes this are simple wrappers around
> > HeapAlloc() that are the same as the "standard" wrappers used in Wine.
> > But they are used only as callbacks aka different usage.
>
> I don't think this particular series is beneficial.  Your script won't
> be able to use these names because they're not called directly.
> I know. But i had written the patches already but before wiping them
> from my tree i thought to send them in for documentation purpose.
> Btw. the unfree-wine.pl has mem_alloc() in there because of the malloc()
> wrapper in the server that happens to have the same name.

bye
	michael

-- 
Michael Stefaniuc               Tel.: [phone]
Sr. Network Engineer            Fax.: [phone]
--------------------------------------------------------------------
Reg. Adresse: Red Hat GmbH, Hauptstätter Strasse 58, 70178 Stuttgart
Handelsregister: Amtsgericht Stuttgart HRB 153243
Geschäftsführer: Brendan Lane, Charlie Peters, Michael Cunningham,
                 Werner Knoblich