Re: [PATCH] dwrite: Make it clear that wine_dbgstr_longlong() output is in hex

[Ken Thomases]

If its output is hex, shouldn't wine_dbgstr_longlong() add the "0x" itself?

-Ken
> On Nov 16, 2016, at 10:57 AM, Nikolay Sivov <nsivov(a)codeweavers.com> wrote:
>
> Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com>
> ---
> dlls/dwrite/font.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/dlls/dwrite/font.c b/dlls/dwrite/font.c
> index 7672aa6..2e1eab0 100644
> --- a/dlls/dwrite/font.c
> +++ b/dlls/dwrite/font.c
> @@ -4373,11 +4373,12 @@ static ULONG WINAPI localfontfilestream_Release(IDWriteFontFileStream *iface)
>     return ref;
> }
>
> -static HRESULT WINAPI localfontfilestream_ReadFileFragment(IDWriteFontFileStream *iface, void const **fragment_start, UINT64 offset, UINT64 fragment_size, void **fragment_context)
> +static HRESULT WINAPI localfontfilestream_ReadFileFragment(IDWriteFontFileStream *iface, void const **fragment_start,
> +    UINT64 offset, UINT64 fragment_size, void **fragment_context)
> {
>     struct dwrite_localfontfilestream *This = impl_from_IDWriteFontFileStream(iface);
>
> -    TRACE_(dwrite_file)("(%p)->(%p, %s, %s, %p)\n",This, fragment_start,
> +    TRACE_(dwrite_file)("(%p)->(%p, 0x%s, 0x%s, %p)\n", This, fragment_start,
>           wine_dbgstr_longlong(offset), wine_dbgstr_longlong(fragment_size), fragment_context);
>
> *fragment_context = NULL;
> @@ -5744,7 +5745,7 @@ static HRESULT WINAPI fontfacereference_EnqueueFileFragmentDownloadRequest(IDWri
> {
>     struct dwrite_fontfacereference *This = impl_from_IDWriteFontFaceReference(iface);
>
> -    FIXME("(%p)->(%s %s): stub\n", This, wine_dbgstr_longlong(offset), wine_dbgstr_longlong(size));
> +    FIXME("(%p)->(0x%s 0x%s): stub\n", This, wine_dbgstr_longlong(offset), wine_dbgstr_longlong(size));
>
> return E_NOTIMPL;
> }
> -- 
> 2.10.2

[PATCH] dwrite: Make it clear that wine_dbgstr_longlong() output is in hex

[Nikolay Sivov]

Maybe, we use it both ways with and without suffix, so I went with a local
change.