[PATCH] ucrtbase: Implement t and j printf length modifiers.
Hi, This adds support for t (ptrdiff_t) and j (intmax_t/uintmax_t) length modifiers. This fixes an issue in Planet Coaster where many in-game values would otherwise show as "jd". I've confirmed the fix works within Steam Play with a local Proton build. These length modifiers have appeared in VS2015 together with z, so putting the code under "_MSVCR_VER >= 140" seems correct. Tests are included and they passed for me on 32-bit and 64-bit. Regards, Ambroz Bizjak
Hi Ambrož, The patch looks mostly good to me but it's required that you add signed-off-by line (https://wiki.winehq.org/Submitting_Patches#The_commit_message). What's the reason for changing: if (sizeof(void*) == 8) to #ifdef _WIN64 ? I think it's better to keep it as is so the code is always compiled. Thanks, Piotr
participants (2)
-
Ambrož Bizjak -
Piotr Caban