Re: winhttp/url.c: Fix of invalid behaviour of WinHttpCrackUrl

[Paul Vriens]

On 03/15/2010 10:56 PM, Maciej Borsz wrote:
> Fix of invalid behaviour of WinHttpCrackUrl when in url is '@'.
>
> For example:
> WinHttpCrackUrl(L"http://example.net/path?var1=example(a)example.com&var2=x&var3=y
> <http://example.net/path?var1=example(a)example.com&var2=x&var3=y>", NULL,
> NULL, sth)
>
> returned:
> scheme(L"http") host(L"example.com <http://example.com>&var2=x&var3=y")
> port(80) path(L"") extra(L"")
>
> instead of:
> scheme(L"http") host(L"example.net <http://example.net>") port(80)
> path(L"/path/") extra(L"?var1=example(a)example.com
> <mailto:example(a)example.com>&var2=x&var3=y")

Hi Maciej,

Could you add a test for this to our testsuite?

You could use winetestbot (https://winetestbot.geldorp.nl/index.pl) to 
verify the behavior on several Windows flavors if needed.

-- 
Cheers,

Paul.

winhttp/url.c: Fix of invalid behaviour of WinHttpCrackUrl

[Maciej Borsz]

Hi!
I added this test to testsuite and resubmitted patch.

Maciej

2010/3/16 Paul Vriens <paul.vriens.wine(a)gmail.com>
> On 03/15/2010 10:56 PM, Maciej Borsz wrote:
> > Fix of invalid behaviour of WinHttpCrackUrl when in url is '@'.
> >
> > For example:
> > WinHttpCrackUrl(L"
> > http://example.net/path?var1=example(a)example.com&var2=x&var3=y
> > <http://example.net/path?var1=example(a)example.com&var2=x&var3=y>", NULL,
> > NULL, sth)
> >
> > returned:
> > scheme(L"http") host(L"example.com <http://example.com>&var2=x&var3=y")
> >
> > port(80) path(L"") extra(L"")
> >
> > instead of:
> > scheme(L"http") host(L"example.net <http://example.net>") port(80)
> >
> > path(L"/path/") extra(L"?var1=example(a)example.com
> > <mailto:example(a)example.com>&var2=x&var3=y")
>
> Hi Maciej,
>
> Could you add a test for this to our testsuite?
>
> You could use winetestbot (https://winetestbot.geldorp.nl/index.pl) to
> verify the behavior on several Windows flavors if needed.
>
> --
> Cheers,
>
> Paul.