On Sun, 19 May 2002, Andreas Mohr wrote: Index: dlls/gdi/freetype.c =================================================================== RCS file: /home/wine/wine/dlls/gdi/freetype.c,v retrieving revision 1.13 diff -u -r1.13 freetype.c --- dlls/gdi/freetype.c 4 Apr 2002 15:30:29 -0000 1.13 +++ dlls/gdi/freetype.c 19 May 2002 21:14:36 -0000 @@ -452,9 +452,9 @@ ft_handle = wine_dlopen("libfreetype.so", RTLD_NOW, NULL, 0); if(!ft_handle) { WINE_MESSAGE( - "Wine cannot find the FreeType font library. To enable Wine to\n" - "use TrueType fonts please install a version of FreeType greater than\n" - "or equal to 2.0.5.\n" + "Wine could not find the FreeType font library. To enable Wine to\n" + "use TrueType fonts please install a version of FreeType\n" + "(plus devel/header file package) greater than or equal to 2.0.5.\n" "http://www.freetype.org\n"); return FALSE; } Index: dlls/wineps/truetype.c =================================================================== RCS file: /home/wine/wine/dlls/wineps/truetype.c,v retrieving revision 1.15 diff -u -r1.15 truetype.c --- dlls/wineps/truetype.c 3 Apr 2002 20:02:39 -0000 1.15 +++ dlls/wineps/truetype.c 19 May 2002 21:14:37 -0000 @@ -593,9 +593,9 @@ ft_handle = wine_dlopen("libfreetype.so", RTLD_NOW, NULL, 0); if(!ft_handle) { WINE_MESSAGE( - "Wine cannot find the FreeType font library. To enable Wine to\n" - "use TrueType fonts please install a version of FreeType greater than\n" - "or equal to 2.0.5.\n" + "Wine could not find the FreeType font library. To enable Wine to\n" + "use TrueType fonts please install a version of FreeType\n" + "(plus devel/header file package) greater than or equal to 2.0.5.\n" "http://www.freetype.org\n"); return TRUE; } I disagree with this bit. This is printed by the Wine binary and the development libraries and headers are not needed for running Wine. Such a message should instead be printed by the configure script if it detects that FreeType libraries or headers are missing. Index: windows/win.c =================================================================== RCS file: /home/wine/wine/windows/win.c,v retrieving revision 1.183 diff -u -r1.183 win.c --- windows/win.c 17 May 2002 02:55:48 -0000 1.183 +++ windows/win.c 19 May 2002 21:14:40 -0000 @@ -1590,7 +1590,10 @@ */ HWND WINAPI FindWindowA( LPCSTR className, LPCSTR title ) { - HWND ret = FindWindowExA( 0, 0, className, title ); + HWND ret; + + WARN("app or wine makes use of FindWindow, which is bad programming since it can hang sometimes on Windows if a window is unresponsive. Use e.g. EnumerateWindows/SendMessageTimeout instead.\n"); + ret = FindWindowExA( 0, 0, className, title ); if (!ret) SetLastError (ERROR_CANNOT_FIND_WND_CLASS); return ret; } I don't think this one is appropriate either. I agree that often FindWindowA is used where there are better solutions. But we are not going to be changing the way existing applications work so there does not seem to be much point in printing this message. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Hiroshima '45 - Czernobyl '86 - Windows '95
On Sun, 19 May 2002, Francois Gouget wrote:
On Sun, 19 May 2002, Andreas Mohr wrote:
Index: dlls/gdi/freetype.c =================================================================== RCS file: /home/wine/wine/dlls/gdi/freetype.c,v retrieving revision 1.13 diff -u -r1.13 freetype.c --- dlls/gdi/freetype.c 4 Apr 2002 15:30:29 -0000 1.13 +++ dlls/gdi/freetype.c 19 May 2002 21:14:36 -0000 @@ -452,9 +452,9 @@ ft_handle = wine_dlopen("libfreetype.so", RTLD_NOW, NULL, 0); if(!ft_handle) { WINE_MESSAGE( - "Wine cannot find the FreeType font library. To enable Wine to\n" - "use TrueType fonts please install a version of FreeType greater than\n" - "or equal to 2.0.5.\n" + "Wine could not find the FreeType font library. To enable Wine to\n" + "use TrueType fonts please install a version of FreeType\n" + "(plus devel/header file package) greater than or equal to 2.0.5.\n" "http://www.freetype.org\n"); return FALSE; } Index: dlls/wineps/truetype.c =================================================================== RCS file: /home/wine/wine/dlls/wineps/truetype.c,v retrieving revision 1.15 diff -u -r1.15 truetype.c --- dlls/wineps/truetype.c 3 Apr 2002 20:02:39 -0000 1.15 +++ dlls/wineps/truetype.c 19 May 2002 21:14:37 -0000 @@ -593,9 +593,9 @@ ft_handle = wine_dlopen("libfreetype.so", RTLD_NOW, NULL, 0); if(!ft_handle) { WINE_MESSAGE( - "Wine cannot find the FreeType font library. To enable Wine to\n" - "use TrueType fonts please install a version of FreeType greater than\n" - "or equal to 2.0.5.\n" + "Wine could not find the FreeType font library. To enable Wine to\n" + "use TrueType fonts please install a version of FreeType\n" + "(plus devel/header file package) greater than or equal to 2.0.5.\n" "http://www.freetype.org\n"); return TRUE; }
I disagree with this bit. This is printed by the Wine binary and the development libraries and headers are not needed for running Wine. Such a message should instead be printed by the configure script if it detects that FreeType libraries or headers are missing.
Actually, the development libraries *are* needed, though the headers are not. This is because the dlopen tries to load "libfreetype.so", NOT "libfreetype.so.6". And, at least on Debian, only the dev package provides the libfreetype.so symlink, the library package itself only contains libfreetype.so.6. (This issue is Debian bug #146136.)
On Mon, May 20, 2002 at 12:09:01PM +0200, Ove Kaaven wrote:
On Sun, 19 May 2002, Francois Gouget wrote:
On Sun, 19 May 2002, Andreas Mohr wrote: @@ -593,9 +593,9 @@ ft_handle = wine_dlopen("libfreetype.so", RTLD_NOW, NULL, 0); if(!ft_handle) { WINE_MESSAGE( - "Wine cannot find the FreeType font library. To enable Wine to\n" - "use TrueType fonts please install a version of FreeType greater than\n" - "or equal to 2.0.5.\n" + "Wine could not find the FreeType font library. To enable Wine to\n" + "use TrueType fonts please install a version of FreeType\n" + "(plus devel/header file package) greater than or equal to 2.0.5.\n" "http://www.freetype.org\n"); return TRUE; }
I disagree with this bit. This is printed by the Wine binary and the development libraries and headers are not needed for running Wine. Such a message should instead be printed by the configure script if it detects that FreeType libraries or headers are missing.
Actually, the development libraries *are* needed, though the headers are not. This is because the dlopen tries to load "libfreetype.so", NOT "libfreetype.so.6". And, at least on Debian, only the dev package provides the libfreetype.so symlink, the library package itself only contains libfreetype.so.6. (This issue is Debian bug #146136.)
Ah, thanks for enlightening us ! :-) (that's probably what prompted me to add this message in the first place) As it's probably only a Debian specific bug (or isn't it ?), I think changing the message to include devel stuff is still wrong, though... (as having devel stuff usually isn't required) -- Andreas Mohr Stauferstr. 6, D-71272 Renningen, Germany Tel. +49 7159 800604 http://mohr.de.tt
On Mon, 20 May 2002, Andreas Mohr wrote:
As it's probably only a Debian specific bug (or isn't it ?), I think changing the message to include devel stuff is still wrong, though... (as having devel stuff usually isn't required)
Well, I'm going to change the Debian package to dlopen libfreetype.so.6 instead of libfreetype.so, but it would be nice if it was fixed in Wine too, or at least have it #defined'd somewhere so the source package only need to change it one place instead of two.
Ove Kaaven <ovehk(a)ping.uio.no> writes:
Well, I'm going to change the Debian package to dlopen libfreetype.so.6 instead of libfreetype.so, but it would be nice if it was fixed in Wine too, or at least have it #defined'd somewhere so the source package only need to change it one place instead of two.
I have a configure test to do that automagically, I'll put it in. -- Alexandre Julliard julliard(a)winehq.com
I have a configure test to do that automagically, I'll put it in.
So could we inform the user at the end of configure that he must install freetype-devel if he wants to use true type fonts ? ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com
Actually, the development libraries *are* needed, though the headers are
not. This is because the dlopen tries to load "libfreetype.so", NOT "libfreetype.so.6". And, at least on Debian, only the dev package provides the libfreetype.so symlink, the library package itself only contains libfreetype.so.6. (This issue is Debian bug #146136.) Ah, thanks for enlightening us ! :-)
(that's probably what prompted me to add this message in the first place)
As it's probably only a Debian specific bug (or isn't it ?),
It isn't. I'm using freetype 2.0.9-2 under RH 7.3 and the symlink isn't provided. It's provided by the freetype-devel package. ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com
participants (5)
-
Alexandre Julliard -
Andreas Mohr -
Francois Gouget -
Ove Kaaven -
Sylvain Petreolle