RegOverridePredefKey stub

[Jens Nestler]

Hello all,

I'm a Windows software developer and I'm trying to execute an application 
under the wine environment.
Now I have a problem introduced with wine 0.9.49.

I use the function RegOverridePredefKey from the advapi32.dll.
In wine 0.9.49 a stub entry for this function was created, but the 
implementation is missing.
To hold my code running, I need any implememtation for this function.
Please apply the attached patch for a stub implementation.

Thank you 
Jens

[Peter Oberndorfer]

On Sonntag 27 Januar 2008, Jens Nestler wrote:
> Hello all,
>
> I'm a Windows software developer and I'm trying to execute an application 
> under the wine environment.
> Now I have a problem introduced with wine 0.9.49.
>
> I use the function RegOverridePredefKey from the advapi32.dll.
> In wine 0.9.49 a stub entry for this function was created, but the 
> implementation is missing.
> To hold my code running, I need any implememtation for this function.
> Please apply the attached patch for a stub implementation.
>
> Thank you 
> Jens

The documentation for the function was copied from MSDN.
So this patch can not be accepted.

If you don't write the documentation yourself submit the patch
without documentation.

It might be useful for the future to add the function prototype to winreg.h.

style problem:
Indention of the new code looks different than the surrounding code.

Greetings Peter

[Robert Shearman]

Jens Nestler wrote:
> /******************************************************************************
> + * RegOverridePredefKey [ADVAPI32.@]
> + *
> + * Maps a predefined registry key to the specified registry key.
> + *
> + * PARAMS
> + *  hKey     [I] A handle to one of the following predefined keys:
> + *               HKEY_CLASSES_ROOT
> + *               HKEY_CURRENT_CONFIG
> + *               HKEY_CURRENT_USER
> + *               HKEY_LOCAL_MACHINE
> + *               HKEY_PERFORMANCE_DATA
> + *               HKEY_USERS
> + *  hNewHKey [I] A handle to an open registry key. This handle is returned by the RegCreateKeyEx or RegOpenKeyEx function. 
> + *               It cannot be one of the predefined keys. The function maps hKey to refer to the hNewHKey key. 
> + *               This affects only the calling process.
> + *               If hNewHKey is NULL, the function restores the default mapping of the predefined key.
> + *
> + * RETURNS
> + *  Success: ERROR_SUCCESS
> + *  Failure: the return value is a nonzero error code defined in Winerror.h
> + * 
> + * NOTES
> + *  The RegOverridePredefKey function is intended for software installation programs.
> + *  It allows them to remap a predefined key, load a DLL component that will be installed on the system, 
> + *  call an entry point in the DLL, and examine the changes to the registry that the component attempted to make. 
> + *  The installation program can then write those changes to the locations intended by the DLL, 
> + *  or make changes to the data before writing it

We appreciate your patch, but you're not allowed to copy information 
from MSDN into the Wine source like this.

-- 
Rob Shearman

[Detlef Riekenberg]

On So, 2008-01-27 at 14:35 +0100, Jens Nestler wrote:
> + * RegOverridePredefKey [ADVAPI32.@]
> + *
> + * Maps a predefined registry key to the specified registry key.
> + *
> + * PARAMS
> + *  hKey     [I] A handle to one of the following predefined keys:

The description in your Patch was copied from MSDN.
http://msdn2.microsoft.com/en-us/library/ms724901.aspx


A description is a good idea.
It should be short and simple, and you must use your own words.


It is expected / needed, that new contributors expicit mention, 
that they did not copy the description from MSDN.


Thanks for helping wine

-- 
 
By by ... Detlef

[Detlef Riekenberg]

On So, 2008-01-27 at 14:35 +0100, Jens Nestler wrote:
> Please apply the attached patch for a stub implementation.

Please send patches to wine-patches(a)winehq.org

Thanks.

-- 
 
By by ... Detlef