Re: [PATCH 5/5] user32: Store the item rects as relative to the items_rect.

[Alexandre Julliard]

Huw Davies <huw(a)codeweavers.com> writes:
> Signed-off-by: Huw Davies <huw(a)codeweavers.com>
> ---
>  dlls/user32/menu.c | 68 ++++++++++++++++++++++++++----------------------------
>  1 file changed, 33 insertions(+), 35 deletions(-)

This fails here:

../../../tools/runtest -q -P wine -T ../../.. -M user32.dll -p user32_test.exe.so win && touch win.ok
win.c:1104: Test failed: window rect does not match: style:exstyle=0x94000000:0x00000000, menu=1, win=(110,100)-(335,300), calc=(110,99)-(335,300)
win.c:1111: Test failed: window rect does not match: style:exstyle=0x94000000:0x00000000, menu=1, win=(110,100)-(335,300), calc=(110,99)-(335,300)
win.c:1140: Test failed: synthetic rect does not match: style:exstyle=0x94000000:0x00000000, menu=1, client=(0,0)-(250,150), calc=(0,-1)-(250,150)
win.c:1104: Test failed: window rect does not match: style:exstyle=0x15c00000:0x00000100, menu=1, win=(-3,-3)-(1923,1203), calc=(-3,-4)-(1923,1203)
win.c:1111: Test failed: window rect does not match: style:exstyle=0x15c00000:0x00000100, menu=1, win=(-3,-3)-(1923,1203), calc=(-3,-4)-(1923,1203)
win.c:1140: Test failed: synthetic rect does not match: style:exstyle=0x15c00000:0x00000100, menu=1, client=(0,0)-(250,150), calc=(0,-1)-(250,150)
win.c:1104: Test failed: window rect does not match: style:exstyle=0x14c00000:0x00000100, menu=1, win=(110,100)-(335,300), calc=(110,99)-(335,300)
win.c:1111: Test failed: window rect does not match: style:exstyle=0x14c00000:0x00000100, menu=1, win=(110,100)-(335,300), calc=(110,99)-(335,300)
win.c:1140: Test failed: synthetic rect does not match: style:exstyle=0x14c00000:0x00000100, menu=1, client=(0,0)-(250,150), calc=(0,-1)-(250,150)
win.c:1104: Test failed: window rect does not match: style:exstyle=0x14c00000:0x00000100, menu=1, win=(110,100)-(335,300), calc=(110,99)-(335,300)
win.c:1111: Test failed: window rect does not match: style:exstyle=0x14c00000:0x00000100, menu=1, win=(110,100)-(335,300), calc=(110,99)-(335,300)
win.c:1140: Test failed: synthetic rect does not match: style:exstyle=0x14c00000:0x00000100, menu=1, client=(0,0)-(250,150), calc=(0,-1)-(250,150)
...

-- 
Alexandre Julliard
julliard(a)winehq.org

[PATCH 5/5] user32: Store the item rects as relative to the items_rect.

[Huw Davies]

On Tue, Mar 28, 2017 at 10:16:46PM +0200, Alexandre Julliard wrote:
> Huw Davies <huw(a)codeweavers.com> writes:
> > Signed-off-by: Huw Davies <huw(a)codeweavers.com>
> > ---
> >  dlls/user32/menu.c | 68 ++++++++++++++++++++++++++----------------------------
> >  1 file changed, 33 insertions(+), 35 deletions(-)
>
> This fails here:
>
> ../../../tools/runtest -q -P wine -T ../../.. -M user32.dll -p user32_test.exe.so win && touch win.ok
> win.c:1104: Test failed: window rect does not match: style:exstyle=0x94000000:0x00000000, menu=1, win=(110,100)-(335,300), calc=(110,99)-(335,300)

Sorry about that.  That'll teach me to:
i.  Run the entire set of tests.
ii. Not to remove mysterious '+1's without more testing (see i.).

Huw.