Re: [PATCH renamed] Add a bunch of api-ms dlls that I was too lazy to commit earlier

[Sebastian Lackner]

On 20.08.2016 07:16, Max Qian wrote:
> Signed-off-by: Max Qian <public(a)maxqia.com>
> ---
>  configure                                                | 16 ++++++++++++++++
>  configure.ac                                             |  8 ++++++++
>  dlls/api-ms-win-core-job-l1-1-0/Makefile.in              |  1 +
>  .../api-ms-win-core-job-l1-1-0.spec                      |  1 +
>  dlls/api-ms-win-core-job-l2-1-0/Makefile.in              |  1 +
>  .../api-ms-win-core-job-l2-1-0.spec                      |  6 ++++++
>  dlls/api-ms-win-core-namespace-l1-1-0/Makefile.in        |  1 +
>  .../api-ms-win-core-namespace-l1-1-0.spec                |  6 ++++++
>  dlls/api-ms-win-core-normalization-l1-1-0/Makefile.in    |  1 +
>  .../api-ms-win-core-normalization-l1-1-0.spec            |  5 +++++
>  dlls/api-ms-win-core-string-obsolete-l1-1-0/Makefile.in  |  1 +
>  .../api-ms-win-core-string-obsolete-l1-1-0.spec          | 10 ++++++++++
>  dlls/api-ms-win-core-toolhelp-l1-1-0/Makefile.in         |  1 +
>  .../api-ms-win-core-toolhelp-l1-1-0.spec                 |  7 +++++++
>  dlls/api-ms-win-eventlog-legacy-l1-1-0/Makefile.in       |  1 +
>  .../api-ms-win-eventlog-legacy-l1-1-0.spec               |  6 ++++++
>  dlls/api-ms-win-shell-shellfolders-l1-1-0/Makefile.in    |  1 +
>  .../api-ms-win-shell-shellfolders-l1-1-0.spec            | 14 ++++++++++++++
>  tools/make_specfiles                                     |  6 ++++++
>  19 files changed, 93 insertions(+)
>  create mode 100644 dlls/api-ms-win-core-job-l1-1-0/Makefile.in
>  create mode 100644 dlls/api-ms-win-core-job-l1-1-0/api-ms-win-core-job-l1-1-0.spec
>  create mode 100644 dlls/api-ms-win-core-job-l2-1-0/Makefile.in
>  create mode 100644 dlls/api-ms-win-core-job-l2-1-0/api-ms-win-core-job-l2-1-0.spec
>  create mode 100644 dlls/api-ms-win-core-namespace-l1-1-0/Makefile.in
>  create mode 100644 dlls/api-ms-win-core-namespace-l1-1-0/api-ms-win-core-namespace-l1-1-0.spec
>  create mode 100644 dlls/api-ms-win-core-normalization-l1-1-0/Makefile.in
>  create mode 100644 dlls/api-ms-win-core-normalization-l1-1-0/api-ms-win-core-normalization-l1-1-0.spec
>  create mode 100644 dlls/api-ms-win-core-string-obsolete-l1-1-0/Makefile.in
>  create mode 100644 dlls/api-ms-win-core-string-obsolete-l1-1-0/api-ms-win-core-string-obsolete-l1-1-0.spec
>  create mode 100644 dlls/api-ms-win-core-toolhelp-l1-1-0/Makefile.in
>  create mode 100644 dlls/api-ms-win-core-toolhelp-l1-1-0/api-ms-win-core-toolhelp-l1-1-0.spec
>  create mode 100644 dlls/api-ms-win-eventlog-legacy-l1-1-0/Makefile.in
>  create mode 100644 dlls/api-ms-win-eventlog-legacy-l1-1-0/api-ms-win-eventlog-legacy-l1-1-0.spec
>  create mode 100644 dlls/api-ms-win-shell-shellfolders-l1-1-0/Makefile.in
>  create mode 100644 dlls/api-ms-win-shell-shellfolders-l1-1-0/api-ms-win-shell-shellfolders-l1-1-0.spec

You will have to split this patch and give each part a meaningful title like:
"api-ms-win-core-job-l1-1-0: Add dll."
Also, there is no need to explain why you didn't send it earlier, especially not
in the subject which will be used as commit message. While reworking the patch,
please also remove the hand written comments in the spec files. When you know
that api-ms-win-core-namespace-l1-1-0 forwards to kernel32 for example, it is
better to add that to ./tools/make_specfiles instead of hoping someone will
find the comments later and update it manually. The same also applies to
api-ms-win-core-normalization-l1-1-0.

Regards,
Sebastian