Re: [PATCH] urlmon/tests: CoInternetCreateSecurityManager not present on W95B

[Jacek Caban]

On 4/13/10 11:49 PM, Detlef Riekenberg wrote:
> ---
>   dlls/urlmon/tests/sec_mgr.c |   17 ++++++++++++-----
>   1 files changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/dlls/urlmon/tests/sec_mgr.c b/dlls/urlmon/tests/sec_mgr.c
> index e758115..8e39301 100644
> --- a/dlls/urlmon/tests/sec_mgr.c
> +++ b/dlls/urlmon/tests/sec_mgr.c
> @@ -107,8 +107,10 @@ static void test_SecurityManager(void)
>       DWORD zone, size, policy;
>       HRESULT hres;
>
> -    hres = CoInternetCreateSecurityManager(NULL,&secmgr, 0);
> -    ok(hres == S_OK, "CoInternetCreateSecurityManager failed: %08x\n", hres);
> +    hres = CoCreateInstance(&CLSID_InternetSecurityManager, NULL, CLSCTX_INPROC_SERVER,
> +&IID_IInternetSecurityManager, (void **)&secmgr);
> +
> +    ok(hres == S_OK, "CoCreateInstance for IInternetSecurityManager failed: %08x\n", hres);
>       if(FAILED(hres))
>           return;

You're changing what we test here. If you only want to fix tests on 
win98 it's a nice excuse to skip tests. If you want to test 
CLSID_InternetSecurityManager anyway, you should test both 
CLSID_InternetSecurityManager  and CoInternetCreateSecurityManager. Same 
for zone manager patch.

Jacek