Re: [PATCH 2/2] winealsa: Loudly recommend Pulse users to upgrade to handle_underrun.

[Alexandre Julliard]

Joerg-Cyril.Hoehle(a)t-systems.com writes:
> @@ -525,6 +525,9 @@ HRESULT WINAPI AUDDRV_GetAudioEndpoint(const char *key, IMMDevice *dev,
>      if(handle_underrun && ((lconf = make_handle_underrun_config(key)))){
>          err = snd_pcm_open_lconf(&This->pcm_handle, key, stream, SND_PCM_NONBLOCK, lconf);
>          TRACE("Opening PCM device \"%s\" with handle_underrun: %d\n", key, err);
> +        if(err < 0)
> +            ERR("PulseAudio \"%s\" %d without handle_underrun. Audio may hang."
> +                " Please upgrade to alsa_plugins > 1.0.24\n", key, err);

It seems to me this should only apply to the EINVAL case.

-- 
Alexandre Julliard
julliard(a)winehq.org