Re: [WINEALSA] Add Midi IN support
Christian Costa <titan.costa(a)wanadoo.fr> writes:
+ int npfd; + struct pollfd *pfd; + + npfd = snd_seq_poll_descriptors_count(midiSeq, POLLIN); + pfd = (struct pollfd *)alloca(npfd * sizeof(struct pollfd));
You should not use alloca in Wine, it's not portable enough. -- Alexandre Julliard julliard(a)winehq.com
On Thu, 08 Jan 2004 16:46:53 -0800, Alexandre Julliard wrote:
You should not use alloca in Wine, it's not portable enough.
Could we take the glib implementation of alloca and stick it into libwine_port? IIRC in glib it uses the system implementation unless it's not good enough or missing, in which case it provides an emulation.
On Fri, Jan 09, 2004 at 12:03:10PM +0000, Mike Hearn wrote:
On Thu, 08 Jan 2004 16:46:53 -0800, Alexandre Julliard wrote:
You should not use alloca in Wine, it's not portable enough.
Could we take the glib implementation of alloca and stick it into libwine_port? IIRC in glib it uses the system implementation unless it's not good enough or missing, in which case it provides an emulation.
And I always thought alloca was a compiler builtin. But why not just use HeapAlloc() ? Ciao, Marcus
Marcus Meissner wrote:
On Fri, Jan 09, 2004 at 12:03:10PM +0000, Mike Hearn wrote:
On Thu, 08 Jan 2004 16:46:53 -0800, Alexandre Julliard wrote:
You should not use alloca in Wine, it's not portable enough.
Could we take the glib implementation of alloca and stick it into libwine_port? IIRC in glib it uses the system implementation unless it's not good enough or missing, in which case it provides an emulation.
And I always thought alloca was a compiler builtin.
But why not just use HeapAlloc() ?
Of course yes. It just comes from an alsa example I saw... Christian
Ciao, Marcus
participants (4)
-
Alexandre Julliard -
Christian Costa -
Marcus Meissner -
Mike Hearn