Re: [2/2] shell32: Define PT_FOLDERW.
On Sat, Apr 4, 2009 at 6:59 AM, Nicolas Le Cam <niko.lecam(a)gmail.com> wrote:
Define PT_FOLDERW in pidl.h to complete this series.
You're changing the indent of some of the defines. If you're going to change some, change them all to make them consistent (PT_COMP has two tabs). -- -Austin
2009/4/4 Austin English <austinenglish(a)gmail.com>:
On Sat, Apr 4, 2009 at 6:59 AM, Nicolas Le Cam <niko.lecam(a)gmail.com> wrote:
Define PT_FOLDERW in pidl.h to complete this series.
You're changing the indent of some of the defines. If you're going to change some, change them all to make them consistent (PT_COMP has two tabs).
-- -Austin
Hi Austin, PT_COMP has two tabs to be aligned with other defines (TAB is defined as 8 chars large as I read it multiple times on this list). I just wanted to uniformise this part of the file, if needed I can resend this series without them. Thanks for the review -- Nicolas Le Cam
On Sat, Apr 4, 2009 at 11:55 AM, Nicolas Le Cam <niko.lecam(a)gmail.com> wrote:
2009/4/4 Austin English <austinenglish(a)gmail.com>:
On Sat, Apr 4, 2009 at 6:59 AM, Nicolas Le Cam <niko.lecam(a)gmail.com> wrote:
Define PT_FOLDERW in pidl.h to complete this series.
You're changing the indent of some of the defines. If you're going to change some, change them all to make them consistent (PT_COMP has two tabs).
-- -Austin
Hi Austin,
PT_COMP has two tabs to be aligned with other defines (TAB is defined as 8 chars large as I read it multiple times on this list). I just wanted to uniformise this part of the file, if needed I can resend this series without them.
Whoops, my editor's fault, sorry. The other areas of the define aren't uniform, but it's not a terribly big deal. I only mention it in case you resend the patch set. -- -Austin
2009/4/4 Austin English <austinenglish(a)gmail.com>:
On Sat, Apr 4, 2009 at 11:55 AM, Nicolas Le Cam <niko.lecam(a)gmail.com> wrote:
2009/4/4 Austin English <austinenglish(a)gmail.com>:
On Sat, Apr 4, 2009 at 6:59 AM, Nicolas Le Cam <niko.lecam(a)gmail.com> wrote:
Define PT_FOLDERW in pidl.h to complete this series.
You're changing the indent of some of the defines. If you're going to change some, change them all to make them consistent (PT_COMP has two tabs).
-- -Austin
Hi Austin,
PT_COMP has two tabs to be aligned with other defines (TAB is defined as 8 chars large as I read it multiple times on this list). I just wanted to uniformise this part of the file, if needed I can resend this series without them.
Whoops, my editor's fault, sorry. The other areas of the define aren't uniform, but it's not a terribly big deal. I only mention it in case you resend the patch set.
-- -Austin
Strange, it's uniform on mine ... at least for the #define PT_.. part -- Nicolas Le Cam
participants (2)
-
Austin English -
Nicolas Le Cam