Re: xinput implementation

[Andrew Fenn]

On Fri, Sep 12, 2008 at 1:04 AM, chourmovs vs <chourmovs(a)gmail.com> wrote:
> No sorry
> No time and no skill for that, but maybe i could help doing some tests

In that case I will have a try at implementing it. Can someone have a
look at this patch I made and offer any advice on where I may be going
wrong (incorrect syntax, etc).

This patch lets me load Assassin's Creed without complaining about
missing the native dll (it's a start I guess), problem is that
Assassin's Creed is so slow it's impossible to use for testing with a
joystick.

Regards,
Andrew

xinput implementation

[Henri Verbeet]

2008/9/11 Andrew Fenn <andrewfenn(a)gmail.com>:
> In that case I will have a try at implementing it. Can someone have a
> look at this patch I made and offer any advice on where I may be going
> wrong (incorrect syntax, etc).

The directory should be called after the dll. Ie, xinput1_3 instead of
xinput. You also don't generally want to submit changes to
autogenerated files like configure or dlls/Makefile.in, although IIRC
they will just be ignored.

xinput implementation

[Vitaliy Margolen]

Henri Verbeet wrote:
> 2008/9/11 Andrew Fenn <andrewfenn(a)gmail.com>:
> > In that case I will have a try at implementing it. Can someone have a
> > look at this patch I made and offer any advice on where I may be going
> > wrong (incorrect syntax, etc).
>
> The directory should be called after the dll. Ie, xinput1_3 instead of
> xinput. You also don't generally want to submit changes to
> autogenerated files like configure or dlls/Makefile.in, although IIRC
> they will just be ignored.

But you need to submit changes to files that these auto-generated files are
 created from. In this case configure.ac

I will add that you need to create a proper DllMain() function. See any
other stab dlls for examples.

Makefiles please use tabs and set your tab size to 8 spaces.

Why do you need libxinput? xinput is a standard dll.

Vitaliy.

xinput implementation

[Henri Verbeet]

2008/9/12 Vitaliy Margolen <wine-devel(a)kievinfo.com>:
> But you need to submit changes to files that these auto-generated files are
>  created from. In this case configure.ac

This is actually all autogenerated by tools/make_makefiles from git.
> Why do you need libxinput? xinput is a standard dll.

The input library for xinput1_3.dll is called xinput.lib