Re: kernel32: improve GetNumaHighestNodeNumber

[Matteo Bruni]

2014-03-17 11:56 GMT+01:00 Austin English <austinenglish(a)gmail.com>:
> Fixes https://bugs.winehq.org/show_bug.cgi?id=35596
>
> --
> -Austin
>
> diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c
> index 60156aa..86055d3 100644
> --- a/dlls/kernel32/process.c
> +++ b/dlls/kernel32/process.c
> @@ -3911,9 +3911,9 @@ HRESULT WINAPI RegisterApplicationRecoveryCallback(APPLICATION_RECOVERY_CALLBACK */
> BOOL WINAPI GetNumaHighestNodeNumber(PULONG highestnode)
>  {
> -    FIXME("(%p): stub\n", highestnode);
> -    SetLastError(ERROR_CALL_NOT_IMPLEMENTED);
> -    return FALSE;
> +    *highestnode = 0;
> +    WARN("(%p): semi-stub\n", highestnode);
> +    return TRUE;

Not a big deal I guess but I don't think WARN is appropriate here, it
should still be a FIXME IMO.