Re: [PATCH] windowscodecs/tests: handle failure to create png decoder

[Nikolay Sivov]

On 30.09.2015 18:54, Aric Stewart wrote:
> Signed-off-by: Aric Stewart <aric(a)codeweavers.com>
> ---
>   dlls/windowscodecs/tests/pngformat.c | 4 ++++
>   1 file changed, 4 insertions(+)

If this is about fixing macos failures, Vincent pointed out that there 
was a decision at some point to fix broken builds and not to workaround 
that in test code.

[PATCH] windowscodecs/tests: handle failure to create png decoder

[Vincent Povirk]

> If this is about fixing macos failures, Vincent pointed out that there was a
> decision at some point to fix broken builds and not to workaround that in
> test code.

AFAICT this patch won't actually prevent failures, just skip later
tests after the failure so they don't crash.

[PATCH] windowscodecs/tests: handle failure to create png decoder

[Aric Stewart]

On 9/30/15 11:08 AM, Vincent Povirk wrote:
> > If this is about fixing macos failures, Vincent pointed out that there was a
> > decision at some point to fix broken builds and not to workaround that in
> > test code.
>
> AFAICT this patch won't actually prevent failures, just skip later
> tests after the failure so they don't crash.

Correct. I am leaving in the failures because I agree they are important. I just want to have it register as a failure and not as a crash.

-aric