Re: [2/14]hid: break HidD_ functions out into their own module
On Jun 25, 2015, at 9:15 AM, Aric Stewart <aric(a)codeweavers.com> wrote: --- a/dlls/hid/main.c +++ b/dlls/hid/main.c @@ -39,43 +35,9 @@ BOOL WINAPI DllMain(HINSTANCE hInstDLL, DWORD fdwReason, LPVOID lpv) { switch(fdwReason) { - case DLL_WINE_PREATTACH: - return FALSE; /* prefer native version */ This is minor, but I don’t think we should prefer the builtin hid.dll until we’re done implementing it.
Chip
Charles Davis <cdavis5x(a)gmail.com> writes:
On Jun 25, 2015, at 9:15 AM, Aric Stewart <aric(a)codeweavers.com> wrote: --- a/dlls/hid/main.c +++ b/dlls/hid/main.c @@ -39,43 +35,9 @@ BOOL WINAPI DllMain(HINSTANCE hInstDLL, DWORD fdwReason, LPVOID lpv) { switch(fdwReason) { - case DLL_WINE_PREATTACH: - return FALSE; /* prefer native version */ This is minor, but I don’t think we should prefer the builtin hid.dll until we’re done implementing it.
There's no such thing as a dll being done ;-) It's OK to change it as soon as the dll starts doing something useful. It should be a separate patch though. -- Alexandre Julliard julliard(a)winehq.org
participants (2)
-
Alexandre Julliard -
Charles Davis