re: wininet [1/2]: Add test for FtpGetCurrentDirectoryA
29 Nov
2007
29 Nov
'07
7:49 a.m.
Nice to see you contributing tests! Three comments: 1. you seem to have ragged indentation. Did you remember to remove all tabs? (Hmm. Our doc on the tab issue is a bit weak: neither http://winehq.org/site/sending_patches http://winehq.org/site/docs/winedev-guide/style-notes really capture the current anti-tab mood.) 2. You have a nice testDir variable, but then you hard-code "pub" somewhere. Use the variable everywhere. 3. Did you make sure the new tests pass on Windows? -- Wine for Windows ISVs: http://kegel.com/wine/isv
6595
Age (days ago)
6595
Last active (days ago)
0 comments
1 participants
participants (1)
-
Dan Kegel