Re: gdiplus/tests: Use printf() for memory dumps instead of trace(). (try 2)
On 2015-03-29 12:29, Thomas Faber wrote:
trace is unsuitable since it adds a file:line prefix every time.
Is there a preferred way to handle this instead of using printf? Or is this simply a case that seems pointless to fix because tests should never fail anyway (in which case a patch to remove these dumps completely might make sense)? Thanks! -Thomas PS: Here's what I see with trace(), which was my reasoning for the patch: image.c:4241: Test marked todo: 16: data should match image.c:4249: 40image.c:4249: 40image.c:4249: 40image.c:4249: 40image.c:4249: 40image.c:4249: 40image.c:4249: 80image.c:4249: 80image.c:4249: 80image.c:4249: 80image.c:4249: 80image.c:4249: 80image.c:4249: 40image.c:4249: 40image.c:4249: 40image.c:4249: 40image.c:4249: 40image.c:4249: 40image.c:4249: 40image.c:4249: 40image.c:4249: 40image.c:4249: 40image.c:4249: 40image.c:4249: 40image.c:4250:
This might be considered a bug in the trace() function. The debug output functions we use outside tests can be used in this way without printing the prefix multiple times.
participants (2)
-
Thomas Faber -
Vincent Povirk