Re: gdi32: Add support for loading scalable font resources.

[Dmitry Timoshkov]

Huw Davies <huw(a)codeweavers.com> wrote:
> +    if (size.u.LowPart < sizeof( *dos )) goto fail;

Testing LowPart only could not work for large sizes.

-- 
Dmitry.

gdi32: Add support for loading scalable font resources.

[Huw Davies]

On Fri, Mar 30, 2012 at 07:31:54PM +0900, Dmitry Timoshkov wrote:
> Huw Davies <huw(a)codeweavers.com> wrote:
> > +    if (size.u.LowPart < sizeof( *dos )) goto fail;
>
> Testing LowPart only could not work for large sizes.

Of course, but we don't care if very large files fail, they won't be
genuine resource files anyway.

Huw.

gdi32: Add support for loading scalable font resources.

[Dmitry Timoshkov]

Huw Davies <huw(a)codeweavers.com> wrote:
> > > +    if (size.u.LowPart < sizeof( *dos )) goto fail;
> >
> > Testing LowPart only could not work for large sizes.
>
> Of course, but we don't care if very large files fail, they won't be
> genuine resource files anyway.

Then returning 64-bit sizes doesn't make sence, and large sizes should be
detected and rejected.

-- 
Dmitry.