Re: services.exe[3/3]: start a local RPC server and make advapi32 connect/disconnect to it on service manager handle creation/destruction

[Robert Shearman]

Mikolaj Zalewski wrote:
> +    /* Compatible with Windows function 0x0f */
> +    DWORD svcctl_OpenSCManagerW(
> +        SvcCtlRpcHandle rpc_handle,
> +        [in,unique,string] LPCWSTR MachineName,
> +        [in,unique,string] LPCWSTR DatabaseName,

The string attribute should be redundant as LPCWSTR should already be 
declared as a string type. I also noticed this redundancy in your fourth 
services patch.
> +    if ((err = RpcServerInqBindings(&pbindingVector)) != ERROR_SUCCESS)
> +    {
> +        WINE_ERR("RpcServerInqBindings failed with error %u\n", err);
> +        return err;
> +    }

What's the purpose of this? You don't actually use the binding vector 
anywhere.

-- 
Rob Shearman