Re: [PATCH 5/5] wined3d: Use rendertarget views for color output instead of surfaces.

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2014-08-21 09:55, schrieb Henri Verbeet:
> +    if (swapchain_desc->backbuffer_count && FAILED(hr = wined3d_rendertarget_view_create_from_surface(
> +            surface_from_resource(wined3d_texture_get_sub_resource(swapchain->back_buffers[0], 0)),
> +            NULL, &wined3d_null_parent_ops, &device->back_buffer_view)))
> +    {
> +        ERR("Failed to create rendertarget view, hr %#x.\n", hr);
> +        goto err_out;
> +    }
> Having an implicit back buffer render target view managed by wined3d seems a bit odd. Why not let the client libraries create and set the render target view after device creation? That would be similar to what a d3d10 app does after D3D10CreateDeviceAndSwapChain.
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJT9huWAAoJEN0/YqbEcdMwvxMQAIcE7cZnRLTTgECUoxQMWkA5
hobDWConkMr0LGeCMt0Aw98UPsq5n7V/qivYdayudgWbt2YkrRnKq6+d7SIuaWBd
QnA0q3CRpWa/v4BKfsXN7t2OKnDwwYCeQoW+qqBpentNEblxVAdh4Rh+/AQZ1Oim
PjWdi0Nl31VPnRTQq/GpiHFNY87T9l46hsd5W1GfxY8gPuNxBn0P1xDDsYqG8IxQ
3GH5gw3YIk/JTlvX0nSHQbo05WCgxlGUJ+i7LMotlNth0itEBPOI8EqefEwTdfVO
a/6O9xdt7FCNuZSb9yA9nCvn65D8k9hJxYjltF2aouLlbbtuV9CeuNrsxQhqWRA4
vKH5agUKa7dH8aGEaEKk1nrcO9r1U//wGVT1jaZRyWaPx2+o/J/RPIGwEx/HZtyv
jInN2QpVSQo4YqSRLHB6geJ3K5OvTAVI4X4QtFXiFQ6IABTmsjlIdxF30fFSmOos
+45ohC/GguOJKgvApgWix7xRAX7N1U3QaDsNyaQofJ6hDY7EdMW5Ptz58qBqUv6x
4P6PJ+m4BS5yj+hIsOC1HlwQnMRn4JexTfsg4E/mB5Laa3RONQ8x5aX00G3gs6Sv
FozirZyoP4n3d7X0nRkRf4qljlW8SsssWhy7paTLgtLJwdFwy97wWLubdZuljeeg
GxCvkXAnRBScDk9IE4z4
=UuRt
-----END PGP SIGNATURE-----

[PATCH 5/5] wined3d: Use rendertarget views for color output instead of surfaces.

[Henri Verbeet]

On 21 August 2014 18:17, Stefan Dösinger <stefandoesinger(a)gmail.com> wrote:
> Having an implicit back buffer render target view managed by wined3d seems a bit odd. Why not let the client libraries create and set the render target view after device creation? That would be similar to what a d3d10 app does after D3D10CreateDeviceAndSwapChain.

Not that much more odd than the implicit back/front buffer surfaces
themselves. That said, moving it out into the client libraries could
perhaps work, and maybe even be worth it. Note that it isn't just a
matter of setting it after device creation though, it's involved in
resets as well.