Re: [PATCH] mshtml: Add IHTMLTableCell::bgColor property implementation.

[Jacek Caban]

Hi Jactry,

On 08/29/14 17:17, Jactry Zeng wrote:
> --- a/dlls/mshtml/htmltablecell.c
> +++ b/dlls/mshtml/htmltablecell.c
> @@ -174,15 +174,47 @@ static HRESULT WINAPI HTMLTableCell_get_vAlign(IHTMLTableCell *iface, BSTR *p)
>  static HRESULT WINAPI HTMLTableCell_put_bgColor(IHTMLTableCell *iface, VARIANT v)
>  {
>      HTMLTableCell *This = impl_from_IHTMLTableCell(iface);
> -    FIXME("(%p)->(%s)\n", This, debugstr_variant(&v));
> -    return E_NOTIMPL;
> +    nsAString strColor;
> +    nsresult nsres;
> +
> +    TRACE("(%p)->(%s)\n", This, debugstr_variant(&v));
> +
> +    nsAString_InitDepend(&strColor, V_BSTR(&v));
> +    variant_to_nscolor(&v, &strColor);

Please handle variant_to_nscolor errors here.

Jacek

[PATCH] mshtml: Add IHTMLTableCell::bgColor property implementation.

[Jactry Zeng]

Hi Jacek,
2014-08-29 23:24 GMT+08:00 Jacek Caban <jacek(a)codeweavers.com>:
> Please handle variant_to_nscolor errors here.

A newer version was sent.
Thanks for your review!

-- 
Regards,
Jactry Zeng