Warnings left when compiling on GNU/Linux
When compiling on SUSE LINUX 9.2 using GCC 3.3.5 the following are the only warnings I'm getting for current Wine CVS: metafile.c:395: warning: `test_mf_PatternBrush' defined but not used rtlstr.c:552: warning: `test_RtlUpcaseUnicodeChar' defined but not used rtlstr.c:578: warning: `test_RtlUpcaseUnicodeString' defined but not used rtlstr.c:629: warning: `test_RtlDowncaseUnicodeString' defined but not used hlp2sgml.c:219: warning: `%x' yields only last 2 digits of year in some locales On FreeBSD 4.10 using GCC 3.3.4 I am also seeing the following one: fd.c:572: warning: right shift count >= width of type fd.c:574: warning: right shift count >= width of type Any chance we could get rid of these? :-) Gerald
Gerald Pfeifer wrote:
When compiling on SUSE LINUX 9.2 using GCC 3.3.5 the following are the only warnings I'm getting for current Wine CVS:
metafile.c:395: warning: `test_mf_PatternBrush' defined but not used rtlstr.c:552: warning: `test_RtlUpcaseUnicodeChar' defined but not used rtlstr.c:578: warning: `test_RtlUpcaseUnicodeString' defined but not used rtlstr.c:629: warning: `test_RtlDowncaseUnicodeString' defined but not used hlp2sgml.c:219: warning: `%x' yields only last 2 digits of year in some locales
On FreeBSD 4.10 using GCC 3.3.4 I am also seeing the following one:
fd.c:572: warning: right shift count >= width of type fd.c:574: warning: right shift count >= width of type
Any chance we could get rid of these? :-) Oh, if you "complain" ;) that you don't have enough warnings left i recommend compiling Wine with gcc4. LOTS of warnings like this one: warning: pointer targets in passing argument 1 of ‘$function’ differ in signedness I've thought of taking care of those but i'm not sure if it's a good idea.
bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 System Administration Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart
Hi Gerald, The metafile.c warning is because of a test that is commented out in dlls/gdi/test/metafile.c. It's commented out instead of protected with todo because it doesn't just fail, it crashes. Perhaps the rtlstr test warnings are there for similar reasons. There's a patch to make the metafile test pass, which also un-comments the test, at http://www.winehq.org/hypermail/wine-patches/2004/12/0191.html The patch hasn't been committed, but if anybody wants to make it nicer and try again, feel free to do so. Thanks, - Walter On Wed, 5 Jan 2005, Gerald Pfeifer wrote:
When compiling on SUSE LINUX 9.2 using GCC 3.3.5 the following are the only warnings I'm getting for current Wine CVS:
metafile.c:395: warning: `test_mf_PatternBrush' defined but not used rtlstr.c:552: warning: `test_RtlUpcaseUnicodeChar' defined but not used rtlstr.c:578: warning: `test_RtlUpcaseUnicodeString' defined but not used rtlstr.c:629: warning: `test_RtlDowncaseUnicodeString' defined but not used hlp2sgml.c:219: warning: `%x' yields only last 2 digits of year in some locales
On FreeBSD 4.10 using GCC 3.3.4 I am also seeing the following one:
fd.c:572: warning: right shift count >= width of type fd.c:574: warning: right shift count >= width of type
Any chance we could get rid of these? :-)
Gerald
Le mer 05/01/2005 à 15:12, Walt Ogburn a écrit :
Hi Gerald,
The metafile.c warning is because of a test that is commented out in dlls/gdi/test/metafile.c. It's commented out instead of protected with todo because it doesn't just fail, it crashes. Perhaps the rtlstr test warnings are there for similar reasons.
The rtlstr tests are commented out because they use a loop (to iterate through chars), and some of them are ok and some others are not. So if we put them in a simple ok test, we'll get failures for some chars, and if we put them in a todo block, then we'll get failures for all the other cases which work fine. We could get on with a todo_table listing for which chars we fail, but I think (Dmitry can correct me as I'm likely wrong here) these tests are locale-dependant, so we're in for more problems using that method. IOW, don't count those tests to be uncommented tomorrow morning.
There's a patch to make the metafile test pass, which also un-comments the test, at
http://www.winehq.org/hypermail/wine-patches/2004/12/0191.html
The patch hasn't been committed, but if anybody wants to make it nicer and try again, feel free to do so.
Thanks, - Walter
On Wed, 5 Jan 2005, Gerald Pfeifer wrote:
When compiling on SUSE LINUX 9.2 using GCC 3.3.5 the following are the only warnings I'm getting for current Wine CVS:
metafile.c:395: warning: `test_mf_PatternBrush' defined but not used rtlstr.c:552: warning: `test_RtlUpcaseUnicodeChar' defined but not used rtlstr.c:578: warning: `test_RtlUpcaseUnicodeString' defined but not used rtlstr.c:629: warning: `test_RtlDowncaseUnicodeString' defined but not used hlp2sgml.c:219: warning: `%x' yields only last 2 digits of year in some locales
On FreeBSD 4.10 using GCC 3.3.4 I am also seeing the following one:
fd.c:572: warning: right shift count >= width of type fd.c:574: warning: right shift count >= width of type
Any chance we could get rid of these? :-)
Gerald
Vincent Béron <vberon(a)mecano.gme.usherb.ca> writes:
So if we put them in a simple ok test, we'll get failures for some chars, and if we put them in a todo block, then we'll get failures for all the other cases which work fine.
We could get on with a todo_table listing for which chars we fail, but I think (Dmitry can correct me as I'm likely wrong here) these tests are locale-dependant, so we're in for more problems using that method.
The tests should be fixed to not hardcode character values (or maybe only test a-z), we don't use the exact same Unicode tables as Microsoft so the test will never succeed 100%, and this won't be fixed unless we find an app that requires it. We don't want to provide our own Unicode tables just to satisfy the tests. -- Alexandre Julliard julliard(a)winehq.org
On Wed, 5 Jan 2005, Walt Ogburn wrote:
There's a patch to make the metafile test pass, which also un-comments the test, at
http://www.winehq.org/hypermail/wine-patches/2004/12/0191.html
The patch hasn't been committed, but if anybody wants to make it nicer and try again, feel free to do so.
Hmm, the patch looks okay, and I didn't see any rejection message or comment from Alexandre, so I wonder why it hasn't been applied. Alexandre? (Perhaps you could just resubmit it, Walt?) Gerald
participants (5)
-
Alexandre Julliard -
Gerald Pfeifer -
Michael Stefaniuc -
Vincent Béron -
Walt Ogburn