Re: [PATCH 1/5] wined3d: Store valid locations in the resource.
On 3 October 2013 13:08, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
--- dlls/wined3d/volume.c | 46 +++++++++++++++++++++--------------------- dlls/wined3d/wined3d_private.h | 6 ++++-- 2 files changed, 27 insertions(+), 25 deletions(-)
What about surfaces and buffers?
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-10-03 13:14, schrieb Henri Verbeet:
On 3 October 2013 13:08, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
--- dlls/wined3d/volume.c | 46 +++++++++++++++++++++--------------------- dlls/wined3d/wined3d_private.h | 6 ++++-- 2 files changed, 27 insertions(+), 25 deletions(-)
What about surfaces and buffers? Will be updated as well. See http://www.winehq.org/pipermail/wine-devel/2013-October/101575.html for the surface part and more explanations. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJSTVN9AAoJEN0/YqbEcdMw9hwP/insKmUabEOtn+87MOY8RSqw gEHY1dYyi8L+ECVcjJx/x7BzLGDDC8lfISWHQkVZ6RcF7X8TegVwxQwgJY1e1isM YD8ECNRW96mBgSumrvtLUJVvdOlOOW0HU9L4U7DvqXLTrc1n6toaCvALW2v+OyTz aZy2+5iRu6SL5zoTsdt5AAOVg/xqBaY1svnBvEAyDJ3w/ztPmLReMGaM95cLzStG 6NzPhg3nd4YCb2hHvpAXypM9PQLFgMAGqOIS/4PXIVa1N5sbnNABWs0tmqOeP8DJ Oul8vSsNysEViWdsRBvQFa9m3s5lvpY3RMXKdfWjQjjpDQv6Ii3f6D8xzEUnguI4 BrysvAkrz2dcQAdkLm2LmLIe9pCEbL+FHaFXjydgRWBLY7iK5Y68WMpVyyKA8SVv jYdd/e+hLu1IvYWRgSU9Z3tNBnIwTqZyrb6exwlsUztvkoMZvTKEGuDShnTvPLX5 FornFmxCYflneZO6fjFtI+y9OgAQLsdqCPKb6JzPlQS+d3baR1IZeY/j9/iS8U0I 0xknAEGZ63gVUWONJB55S6Kt7tSEjI7fTMZfKBPm+oDU36//2PxDtuA58K7aUnnG +dAOSz0Fndpnei7dZQSCSNyCwujWqetAdXK3n13uzHxL2QZIxWiHrEo8nqawVLWL wkzlLCqE9605fthCQYf6 =Q81u -----END PGP SIGNATURE-----
On 3 October 2013 13:22, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
Am 2013-10-03 13:14, schrieb Henri Verbeet:
On 3 October 2013 13:08, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
--- dlls/wined3d/volume.c | 46 +++++++++++++++++++++--------------------- dlls/wined3d/wined3d_private.h | 6 ++++-- 2 files changed, 27 insertions(+), 25 deletions(-)
What about surfaces and buffers? Will be updated as well. See http://www.winehq.org/pipermail/wine-devel/2013-October/101575.html for the surface part and more explanations. It sounds like you have some ordering issues in that patch set.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-10-03 13:45, schrieb Henri Verbeet:
On 3 October 2013 13:22, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
Will be updated as well. See http://www.winehq.org/pipermail/wine-devel/2013-October/101575.html
for the surface part and more explanations. It sounds like you have some ordering issues in that patch set. Correct. Patches before patch 24 shouldn't be affected by that though. I didn't get around to splitting and recombining patch 24 and some later bugfixes yet due to other priorities.
Unless you mean to imply that you disagree with the ordering of the first 23 patches, where the order is mostly a matter of opinion instead of technical constraints. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSTWsrAAoJEN0/YqbEcdMwXnMP/1mN/d6iy/pXtftkIEvLsDLb Av1zqQpPs92UU/H/TPlkQ0B2jMgBaefpuAsIWFc856lRjPUXUlbZ6cz17G502g7b cqn6idjqEqIpPfF5dQ+U3SY4mAznUI0mxWqGdiqKNyq1uuPA1PoUxS1zTIrK68sQ TXf4CgVsz0wObN7rEdpLUrGY+wPAG0PeNSCQaQsOMkvV5J0QpOHy++p9bOlV7W1K IiwpVdorT7G3ru0KMYVChdsPiFvEVE0uj+/6+b1oewaA3r2XIOKiMeCLhPGgOTnh jJxWfJA+MO3tI1RjUxXC1Pxl5fcuMTbr9saj01+WSfI/BMAnNnzdumo84yX8ME5l ypAu2UwXWSSU4cFPRx4ok/+iQ/JW533QoSZ50j4MevFl4OPAtFl+k8tfpdhfuaop tC/NuvB8SlPFLLsN1ELiBNWXyFdW5LGruTl9Fxb5in1XwQIxy/t4u1aS23cbU30K 3cYYCfk14nG6XWnAmjBq7I+gTWY55P34dIqf/q0bQPtHWUD31lP/Vdi++md8g+32 6FbMQm+/2NZfoX/fJQyRIaDQSnE0NIjpsRfEtKRPqZGehT3D2KbFJIaVJrh/X7w6 LShdXa4q7R+bQyHT6weg4nMcyoHfHDUokUctSgvAsUpVdT/0kMt/Z/kRlEvtcygi KTaXODUsfmXBin8sKlyt =3Dy9 -----END PGP SIGNATURE-----
On 3 October 2013 15:03, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
Am 2013-10-03 13:45, schrieb Henri Verbeet:
It sounds like you have some ordering issues in that patch set. Correct. Patches before patch 24 shouldn't be affected by that though. I didn't get around to splitting and recombining patch 24 and some later bugfixes yet due to other priorities.
Unless you mean to imply that you disagree with the ordering of the first 23 patches, where the order is mostly a matter of opinion instead of technical constraints.
I don't think this patch makes sense before you actually unify the location management. In particular, after this patch you'd have location management in resources that really only does anything for volumes, while from the surface point of view you'd have duplicate location management.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-10-03 16:05, schrieb Henri Verbeet:
I don't think this patch makes sense before you actually unify the location management. In particular, after this patch you'd have location management in resources that really only does anything for volumes, while from the surface point of view you'd have duplicate location management. I think the harm in that is only cosmetic because the surface one will go away, but reordering the patches is easy.
I do prefer to deal with buffers after merging the location management of surfaces and volumes though. Merging buffers will require considerable additional work, most notably removing the buffer conversion code and preferably (but not necessarily) adding an arbvp vertex pipeline that can handle rhw vertices and forwards everything else to the fixed function code. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSTegzAAoJEN0/YqbEcdMw85sP/1Em4RWi2dPAP+fNtGGhBSql sUJcVkGLhSPvqNxLqhzoGMzzh+3JzvmzPtrT3b/BLRZDYemm60x8Mcxirab0RIAv XRLPd0WG1W9xFoft8I8gYSf2MBxidfEKNc/wnusj/6hgni9rPDEfhJfK9AwJt0ok NnVuvSl6NCPEhyjPX0A/Dh/rqOC1+h8bmUnKKQaONnjNiOpcbrw0LHmLbPXC1UOE WjqUJck6tm6FmRHo+pLPQzRqHNZDNqyI4k5BhVy59rDC7wI4xlzSikQGjLv3/ik5 8SQIu6bn+Inq3Ruc+kSoskY1mThEdYZVi3yPkdRwcGHeyihb0klME68z9+xQPqWN ZA3hYpnNlMDb40iMwq0mGeMdbZufsFvYXqe9PsottOhPKeCksNavEe1TFlt0rQFi MukG514G7QMfKRUJtayxvvo5b/ZaxDLs9PCjOH0A9M1ki6nsViw/aAlF/xg2lTC4 ZCziB74bai2ss9OVAZwRWYMUqkDEhp9ot2SE4gnRPnQK/+KY8ncq7boxeohFM0/W ENC8F6E+IfkdENj4vhVICQ5Ttbo0i/NO4LsSe5MqFpvTidQbLTDYNIcKqW7lBJv6 aqw+8DCH7oragx70W4P2VEC0v2p8RHvzVa25Ea/SuktJTsQh/lkul5jijmVsAZPr zjQ6a8VOc+yUONvh/zba =xm5i -----END PGP SIGNATURE-----
participants (2)
-
Henri Verbeet -
Stefan Dösinger