Re: msvcrt: Use Dragon4 algorithm to fix inconsistent rounding behaviour for sprintf and add tests. (try 2)

[Dmitry Timoshkov]

YongHao Hu <christopherwuy(a)gmail.com> wrote:
> +typedef int int32_t;
> +typedef unsigned char uint8_t;
> +typedef unsigned long uint32_t;
> +typedef unsigned long long uint64_t;

Please use appropriate win32 types instead.

Besides using 'typedef unsigned long uint32_t' is wrong.

-- 
Dmitry.

msvcrt: Use Dragon4 algorithm to fix inconsistent rounding behaviour for sprintf and add tests. (try 2)

[YongHao Hu]

Thank you very much for your comment. : ) I had made a new patch.
Apart from this, is there anything to do to improve this patch?
I will be grateful for any advice you can provide.

On 2015年02月27日 12:28, Dmitry Timoshkov wrote:
> YongHao Hu <christopherwuy(a)gmail.com> wrote:
> > +typedef int int32_t;
> > +typedef unsigned char uint8_t;
> > +typedef unsigned long uint32_t;
> > +typedef unsigned long long uint64_t;
> > Please use appropriate win32 types instead.
>
> Besides using 'typedef unsigned long uint32_t' is wrong.