[PATCH 5/6] d3d8/tests: Fix a test failure on Win10 1809 TestBots.

[Zhiyi Zhang]

Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com>
---
 dlls/d3d8/tests/device.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/dlls/d3d8/tests/device.c b/dlls/d3d8/tests/device.c
index 1fe9864c52..ee72ca5e4c 100644
--- a/dlls/d3d8/tests/device.c
+++ b/dlls/d3d8/tests/device.c
@@ -6624,7 +6624,8 @@ static void test_update_volumetexture(void)
 
         hr = IDirect3DDevice8_UpdateTexture(device, (IDirect3DBaseTexture8 *)src, (IDirect3DBaseTexture8 *)dst);
         todo_wine_if (FAILED(hr))
-            ok(SUCCEEDED(hr), "Failed to update texture, hr %#x, case %u.\n", hr, i);
+            ok(SUCCEEDED(hr) || broken(hr == E_FAIL && (i == 6 || i == 7)), /* Win10 1809 TestBots */
+                    "Failed to update texture, hr %#x, case %u.\n", hr, i);
 
         IDirect3DVolumeTexture8_Release(src);
         IDirect3DVolumeTexture8_Release(dst);
-- 
2.20.1

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=67320

Your paranoid android.


=== w1064v1809_ar (32 bit report) ===

d3d8:
device.c:1003: Test failed: The cursor handle is 00010019

[Henri Verbeet]

On Tue, 17 Mar 2020 at 12:16, Zhiyi Zhang <zzhang(a)codeweavers.com> wrote:
> @@ -6624,7 +6624,8 @@ static void test_update_volumetexture(void)
>
> hr = IDirect3DDevice8_UpdateTexture(device, (IDirect3DBaseTexture8 *)src, (IDirect3DBaseTexture8 *)dst);
>          todo_wine_if (FAILED(hr))
> -            ok(SUCCEEDED(hr), "Failed to update texture, hr %#x, case %u.\n", hr, i);
> +            ok(SUCCEEDED(hr) || broken(hr == E_FAIL && (i == 6 || i == 7)), /* Win10 1809 TestBots */
> +                    "Failed to update texture, hr %#x, case %u.\n", hr, i);
> Assuming this is specific to WARP, and not e.g. a peculiarity of
> Windows 10 or something else specific to the testbot, we'd guard this
> with adapter_is_warp().