[PATCH 5/5] winecfg: Distinguish between Windows XP and Windows XP x64
winecfg: Distinguish between Windows XP and Windows XP x64 A 64-bit WINEPREFIX user may want to select XP or XP x64. The two have different kernel versions (NT 5.1 versus NT 5.2). I think this may confuse users though so I send it here (rather than wine-patches) just for the hell of it. Besides, I'm not aware of a use case.
On 10.01.2015 21:44, Ken Sharp wrote:
winecfg: Distinguish between Windows XP and Windows XP x64
A 64-bit WINEPREFIX user may want to select XP or XP x64. The two have different kernel versions (NT 5.1 versus NT 5.2).
I think this may confuse users though so I send it here (rather than wine-patches) just for the hell of it.
Besides, I'm not aware of a use case.
We can probably keep it named Windows XP for both archs, but ifdef version data appropriately so you get 5.2 version on 64 bits and regular 5.1 on 32 bits. P.S. there's no patch so it's hard to say how you planned to fix this.
On 11/01/15 11:22, Nikolay Sivov wrote:
We can probably keep it named Windows XP for both archs, but ifdef version data appropriately so you get 5.2 version on 64 bits and regular 5.1 on 32 bits.
P.S. there's no patch so it's hard to say how you planned to fix this.
D'oh! I've attached it (this time) but I don't think it's necessary. I'd be amazed to see a usage case.
On 11.01.2015 14:33, Ken Sharp wrote:
{ "win7", "Windows 7", 6, 1, 0x1DB1,VER_PLATFORM_WIN32_NT, "Service Pack 1", 1, 0, "WinNT"}, { "vista", "Windows Vista", 6, 0, 0x1772,VER_PLATFORM_WIN32_NT, "Service Pack 2", 2, 0, "WinNT"}, #ifdef _WIN64 - { "winxp64", "Windows XP", 5, 2, 0xECE, VER_PLATFORM_WIN32_NT, "Service Pack 2", 2, 0, "WinNT"}, -#else - { "winxp", "Windows XP", 5, 1, 0xA28, VER_PLATFORM_WIN32_NT, "Service Pack 3", 3, 0, "WinNT"}, + { "winxp64", "Windows XP x64", 5, 2, 0xECE, VER_PLATFORM_WIN32_NT, "Service Pack 2", 2, 0, "WinNT"}, #endif + { "winxp", "Windows XP", 5, 1, 0xA28, VER_PLATFORM_WIN32_NT, "Service Pack 3", 3, 0, "WinNT"},
If we're doing this it should be called "winxp" in both cases, we don't have "win764", so why XP should be different?
On 11/01/15 12:07, Nikolay Sivov wrote:
On 11.01.2015 14:33, Ken Sharp wrote:
{ "win7", "Windows 7", 6, 1, 0x1DB1,VER_PLATFORM_WIN32_NT, "Service Pack 1", 1, 0, "WinNT"}, { "vista", "Windows Vista", 6, 0, 0x1772,VER_PLATFORM_WIN32_NT, "Service Pack 2", 2, 0, "WinNT"}, #ifdef _WIN64 - { "winxp64", "Windows XP", 5, 2, 0xECE, VER_PLATFORM_WIN32_NT, "Service Pack 2", 2, 0, "WinNT"}, -#else - { "winxp", "Windows XP", 5, 1, 0xA28, VER_PLATFORM_WIN32_NT, "Service Pack 3", 3, 0, "WinNT"}, + { "winxp64", "Windows XP x64", 5, 2, 0xECE, VER_PLATFORM_WIN32_NT, "Service Pack 2", 2, 0, "WinNT"}, #endif + { "winxp", "Windows XP", 5, 1, 0xA28, VER_PLATFORM_WIN32_NT, "Service Pack 3", 3, 0, "WinNT"},
If we're doing this it should be called "winxp" in both cases, we don't have "win764", so why XP should be different?
Because Windows XP and Windows XP x64 Edition are different versions entirely.
On 11.01.2015 15:45, Ken Sharp wrote:
On 11/01/15 12:07, Nikolay Sivov wrote:
On 11.01.2015 14:33, Ken Sharp wrote:
{ "win7", "Windows 7", 6, 1, 0x1DB1,VER_PLATFORM_WIN32_NT, "Service Pack 1", 1, 0, "WinNT"}, { "vista", "Windows Vista", 6, 0, 0x1772,VER_PLATFORM_WIN32_NT, "Service Pack 2", 2, 0, "WinNT"}, #ifdef _WIN64 - { "winxp64", "Windows XP", 5, 2, 0xECE, VER_PLATFORM_WIN32_NT, "Service Pack 2", 2, 0, "WinNT"}, -#else - { "winxp", "Windows XP", 5, 1, 0xA28, VER_PLATFORM_WIN32_NT, "Service Pack 3", 3, 0, "WinNT"}, + { "winxp64", "Windows XP x64", 5, 2, 0xECE, VER_PLATFORM_WIN32_NT, "Service Pack 2", 2, 0, "WinNT"}, #endif + { "winxp", "Windows XP", 5, 1, 0xA28, VER_PLATFORM_WIN32_NT, "Service Pack 3", 3, 0, "WinNT"},
If we're doing this it should be called "winxp" in both cases, we don't have "win764", so why XP should be different?
Because Windows XP and Windows XP x64 Edition are different versions entirely.
How so? From user perspective it's same as having Windows 7 32 vs 64 bits. If it implies different NT version we got it covered.
On Jan 12, 2015 12:56 AM, "Ken Sharp" <imwellcushtymelike(a)googlemail.com> wrote:
On 11/01/15 12:07, Nikolay Sivov wrote:
On 11.01.2015 14:33, Ken Sharp wrote:
{ "win7", "Windows 7", 6, 1, 0x1DB1,VER_PLATFORM_WIN32_NT, "Service Pack 1", 1, 0, "WinNT"}, { "vista", "Windows Vista", 6, 0, 0x1772,VER_PLATFORM_WIN32_NT, "Service Pack 2", 2, 0, "WinNT"}, #ifdef _WIN64 - { "winxp64", "Windows XP", 5, 2, 0xECE, VER_PLATFORM_WIN32_NT, "Service Pack 2", 2, 0, "WinNT"}, -#else - { "winxp", "Windows XP", 5, 1, 0xA28, VER_PLATFORM_WIN32_NT, "Service Pack 3", 3, 0, "WinNT"}, + { "winxp64", "Windows XP x64", 5, 2, 0xECE, VER_PLATFORM_WIN32_NT, "Service Pack 2", 2, 0, "WinNT"}, #endif + { "winxp", "Windows XP", 5, 1, 0xA28, VER_PLATFORM_WIN32_NT, "Service Pack 3", 3, 0, "WinNT"},
If we're doing this it should be called "winxp" in both cases, we don't have "win764", so why XP should be different?
Because Windows XP and Windows XP x64 Edition are different versions
entirely. Right, but there isn't the case where Windows xp is 64 bit and not xp64. A 64 bit prefix shouldn't be able to pretend to be a (non-existent) 32 bit version.
participants (3)
-
Austin English -
Ken Sharp -
Nikolay Sivov