Re: mciqtz32: Add basic play capability

[Detlef Riekenberg]

On Sa, 2009-03-28 at 16:36 +0100, Christian Costa wrote:
> +    hr = CoCreateInstance(&CLSID_FilterGraph, NULL,
> CLSCTX_INPROC_SERVER, &IID_IGraphBuilder, (LPVOID*)&wma->pgraph);
> +    if (FAILED(hr)) {
> +        TRACE("Cannot create filtergraph (hr = %x)\n", hr);
> +       return MCIERR_INTERNAL;
> +    }

Again TABs in the Code.
> +
> +    hr = IGraphBuilder_QueryInterface(wma->pgraph,
> &IID_IMediaControl, (LPVOID*)&wma->pmctrl);
> +    if (FAILED(hr)) {
> +       TRACE("Cannot get IMediaControl interface (hr = %x)\n", hr);
> +        return MCIERR_INTERNAL;

TAB again.
And while i read this quote: You leak wma->pmctrl here.


-- 
 
By by ... Detlef

mciqtz32: Add basic play capability

[Christian Costa]

Finally it is wma->pgraph which leaks not wma->pmctrl. Thanks for the 
review.

Bye,
Christian

Detlef Riekenberg a écrit :
> On Sa, 2009-03-28 at 16:36 +0100, Christian Costa wrote:
> > +    hr = CoCreateInstance(&CLSID_FilterGraph, NULL,
> > CLSCTX_INPROC_SERVER, &IID_IGraphBuilder, (LPVOID*)&wma->pgraph);
> > +    if (FAILED(hr)) {
> > +        TRACE("Cannot create filtergraph (hr = %x)\n", hr);
> > +       return MCIERR_INTERNAL;
> > +    }
>
> Again TABs in the Code.
> > +
> > +    hr = IGraphBuilder_QueryInterface(wma->pgraph,
> > &IID_IMediaControl, (LPVOID*)&wma->pmctrl);
> > +    if (FAILED(hr)) {
> > +       TRACE("Cannot get IMediaControl interface (hr = %x)\n", hr);
> > +        return MCIERR_INTERNAL;
>
> TAB again.
> And while i read this quote: You leak wma->pmctrl here.