Re: shell32/tests: Fix a test on Win2k platform and above.

[Paul Vriens]

Nicolas Le Cam wrote:
> Try2: Follow Vincent Povirk's suggestion of removing calls to
> SetWindowLongPtr before destroying windows
>
> Could someone test this patch on Win9x or WinNT ?
>
> On Win2k (and according to test.winehq.org on above platforms) an
> ABN_POSCHANGED message is sent to the last window that is removed.
>
> This patch change the ok to a win_skip in this case.
>
> Tell me if you have a better solution.
>
> Nicolas Le Cam
>
> ------------------------------------------------------------------------

Hi,

The "got unexpected ABN_POSCHANGED notification" messages I had before are now 
gone on my Win95 and NT4 boxes. (It was intermittent before on NT4 btw.)

-- 
Cheers,

Paul.

shell32/tests: Fix a test on Win2k platform and above.

[Nicolas Le Cam]

2009/3/19 Paul Vriens <paul.vriens.wine(a)gmail.com>:
> Nicolas Le Cam wrote:
> > Try2: Follow Vincent Povirk's suggestion of removing calls to
> > SetWindowLongPtr before destroying windows
> >
> > Could someone test this patch on Win9x or WinNT ?
> >
> > On Win2k (and according to test.winehq.org on above platforms) an
> > ABN_POSCHANGED message is sent to the last window that is removed.
> >
> > This patch change the ok to a win_skip in this case.
> >
> > Tell me if you have a better solution.
> >
> > Nicolas Le Cam
> >
> > ------------------------------------------------------------------------
>
> Hi,
>
> The "got unexpected ABN_POSCHANGED notification" messages I had before are
> now gone on my Win95 and NT4 boxes. (It was intermittent before on NT4 btw.)
>
> --
> Cheers,
>
> Paul.

Thanks for your tests Paul. Same goes for Win2k.
I will try to set up a Win98SE VM this week to test it.

-- 
Nicolas Le Cam

shell32/tests: Fix a test on Win2k platform and above.

[Paul Vriens]

Nicolas Le Cam wrote:
> 2009/3/19 Paul Vriens <paul.vriens.wine(a)gmail.com>:
> > Nicolas Le Cam wrote:
> > > Try2: Follow Vincent Povirk's suggestion of removing calls to
> > > SetWindowLongPtr before destroying windows
> > >
> > > Could someone test this patch on Win9x or WinNT ?
> > >
> > > On Win2k (and according to test.winehq.org on above platforms) an
> > > ABN_POSCHANGED message is sent to the last window that is removed.
> > >
> > > This patch change the ok to a win_skip in this case.
> > >
> > > Tell me if you have a better solution.
> > >
> > > Nicolas Le Cam
> > >
> > > ------------------------------------------------------------------------
> >
> > Hi,
> >
> > The "got unexpected ABN_POSCHANGED notification" messages I had before are
> > now gone on my Win95 and NT4 boxes. (It was intermittent before on NT4 btw.)
> >
> > --
> > Cheers,
> >
> > Paul.
>
> Thanks for your tests Paul. Same goes for Win2k.
> I will try to set up a Win98SE VM this week to test it.

Succeeds on my Win98SE box as well (didn't before).

-- 
Cheers,

Paul.