Re: [6/6] windowscodecs: Implement IPropertyBag2::Read
24 Jan
2013
24 Jan
'13
6:05 p.m.
+ if (idx > -1) + { + VariantInit(pvarValue+i); + res = VariantCopy(pvarValue+i, This->values+idx); + phrError[i] = res; + if (FAILED(res)) + break; + } This looks wrong to me. We have an array of error values to set for each read attempt, so it seems like each read should be independent - one failure shouldn't cause us to give up on the others, nor to free the values we already read successfully. If this is really how Windows works, we need a test for it.
4704
Age (days ago)
4704
Last active (days ago)
0 comments
1 participants
participants (1)
-
Vincent Povirk