Re: [PATCH 3/6] d3dx9: Factor out param_type_to_table_type() function.

[Matteo Bruni]

2017-05-24 11:46 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>:
> Signed-off-by: Paul Gofman <gofmanp(a)gmail.com>
> ---
>  dlls/d3dx9_36/preshader.c | 26 ++++++++++++++++++++++----
>  1 file changed, 22 insertions(+), 4 deletions(-)
>
> diff --git a/dlls/d3dx9_36/preshader.c b/dlls/d3dx9_36/preshader.c
> index 262b7c1..bddd74f 100644
> --- a/dlls/d3dx9_36/preshader.c
> +++ b/dlls/d3dx9_36/preshader.c
> @@ -193,7 +193,8 @@ enum pres_value_type
>      PRES_VT_FLOAT,
>      PRES_VT_DOUBLE,
>      PRES_VT_INT,
> -    PRES_VT_BOOL
> +    PRES_VT_BOOL,
> +    PRES_VT_MAX
>  };

I guess you mean PRES_VT_COUNT.
> static const struct
> @@ -260,6 +261,22 @@ struct d3dx_pres_ins
>      struct d3dx_pres_operand output;
>  };
>
> +static enum pres_value_type param_type_to_table_type(D3DXPARAMETER_TYPE type)

In d3d we usually name those the other way around e.g.
table_type_from_param_type().